Re: [PATCH 08/12] xfs_db: remove db/convert.h

Dave Chinner
2019-08-30T05:59:00Z

On Tue, Aug 20, 2019 at 01:32:00PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> db/convert.h conflicts with include/convert.h and since the former only
> has one declaration in it anyway, just get rid of it. We'll need this
> in the next patch to avoid an ugly include mess.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> db/Makefile | 4 ++--
> db/command.c | 1 -
> db/command.h | 1 +
> db/convert.c | 1 -
> db/convert.h | 7 -------
> 5 files changed, 3 insertions(+), 11 deletions(-)
> delete mode 100644 db/convert.h

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com