From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
agruenba@redhat.com, Damien.LeMoal@wdc.com,
Goldwyn Rodrigues <rgoldwyn@suse.de>,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
Matthew Bobrowski <mbobrowski@mbobrowski.org>
Subject: Re: iomap_dio_rw ->end_io improvements
Date: Wed, 4 Sep 2019 07:12:29 +0200 [thread overview]
Message-ID: <20190904051229.GA9970@lst.de> (raw)
In-Reply-To: <20190903221621.GH568270@magnolia>
On Tue, Sep 03, 2019 at 03:16:21PM -0700, Darrick J. Wong wrote:
> The biggest problem with merging these patches (and while we're at it,
> Goldwyn's patch adding a srcmap parameter to ->iomap_begin) for 5.4 is
> that they'll break whatever Andreas and Damien have been preparing for
> gfs2 and zonefs (respectively) based off the iomap-writeback work branch
> that I created off of 5.3-rc2 a month ago.
Does Andreas have changes pending that actually pass an end_io call
back to gfs2? So far it just passed NULL so nothing should change.
If my memory serves me correctly zonefs uses ->end_io, but then again
Damien is asking you to queue it up with the iomap tree, so doing
that trivial rebase shouldn't be an issue.
next prev parent reply other threads:[~2019-09-04 5:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 13:03 iomap_dio_rw ->end_io improvements Christoph Hellwig
2019-09-03 13:03 ` [PATCH 1/2] iomap: split size and error for iomap_dio_rw ->end_io Christoph Hellwig
2019-09-03 14:44 ` Darrick J. Wong
2019-09-03 15:24 ` Matthew Wilcox
2019-09-03 13:03 ` [PATCH 2/2] iomap: move the iomap_dio_rw ->end_io callback into a structure Christoph Hellwig
2019-09-03 14:46 ` Darrick J. Wong
2019-09-03 16:14 ` Matthew Wilcox
2019-09-04 12:51 ` Christoph Hellwig
2019-09-03 21:32 ` iomap_dio_rw ->end_io improvements Matthew Bobrowski
2019-09-03 22:16 ` Darrick J. Wong
2019-09-04 2:19 ` Damien Le Moal
2019-09-04 5:12 ` Christoph Hellwig [this message]
2019-09-04 11:46 ` Andreas Gruenbacher
2019-09-04 17:45 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904051229.GA9970@lst.de \
--to=hch@lst.de \
--cc=Damien.LeMoal@wdc.com \
--cc=agruenba@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mbobrowski@mbobrowski.org \
--cc=rgoldwyn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox