Re: [PATCH 11/15] iomap: use a function pointer for dio submits

Christoph Hellwig
2019-09-05T16:27:25Z

> + if (dio->dops && dio->dops->submit_io) {
> + dio->dops->submit_io(bio, file_inode(dio->iocb->ki_filp),
> + pos);

pos would still fit on the previously line as-is.

> + dio->submit.cookie = BLK_QC_T_NONE;

But I think you should return the cookie from the submit function for
completeness, even if btrfs would currently always return BLK_QC_T_NONE.