Re: [PATCH 1/5] xfs_scrub: remove unnecessary fd parameter from file scrubbers

Dave Chinner
2019-09-09T23:29:58Z

On Thu, Sep 05, 2019 at 08:33:28PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> xfs_scrub's scrub ioctl wrapper functions always take a scrub_ctx and an
> fd, but we always set the fd to ctx->mnt.fd. Remove the redundant
> parameter.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> scrub/phase3.c | 10 +++++-----
> scrub/scrub.c | 34 ++++++++++++----------------------
> scrub/scrub.h | 16 ++++++++--------
> 3 files changed, 25 insertions(+), 35 deletions(-)

Nice little cleanup.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com