Re: [PATCH 2/5] libfrog: share scrub headers

Dave Chinner
2019-09-09T23:36:21Z

On Thu, Sep 05, 2019 at 08:33:34PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> xfs_io and xfs_scrub have nearly identical structures to describe scrub
> types. Combine them into a single header file.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> io/scrub.c | 89 ++++++++++------------------------
> libfrog/Makefile | 2 +
> libfrog/scrub.c | 140 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> libfrog/scrub.h | 29 +++++++++++
> scrub/scrub.c | 141 +++++++++++++++---------------------------------------
> 5 files changed, 238 insertions(+), 163 deletions(-)
> create mode 100644 libfrog/scrub.c
> create mode 100644 libfrog/scrub.h

Looks fine. Not sure we needed all the xfrog prefixes, but getting
this into common code is still a win.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

--
Dave Chinner
david@fromorbit.com