From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: kbuild test robot <lkp@intel.com>, Christoph Hellwig <hch@lst.de>,
kbuild-all@01.org, linux-xfs@vger.kernel.org,
"Darrick J. Wong" <darrick.wong@oracle.com>
Subject: Re: [xfs-linux:iomap-for-next 3/12] include/trace/events/iomap.h:49:39: warning: 'struct page' declared inside parameter list will not be visible outside of this definition or declaration
Date: Tue, 10 Sep 2019 08:47:09 +0200 [thread overview]
Message-ID: <20190910064709.GA31448@lst.de> (raw)
In-Reply-To: <20190908213853.GC16973@dread.disaster.area>
On Mon, Sep 09, 2019 at 07:38:53AM +1000, Dave Chinner wrote:
> > In file included from include/trace/events/iomap.h:15,
> > from <command-line>:
> > >> include/trace/events/iomap.h:49:39: warning: 'struct page' declared inside parameter list will not be visible outside of this definition or declaration
> > TP_PROTO(struct inode *inode, struct page *page, unsigned long off, \
>
> The only file that includes trace/events/iomap.h most definitely
> has already defined struct page, and
>
>
> > include/trace/events/iomap.h:49:18: warning: 'struct inode' declared inside parameter list will not be visible outside of this definition or declaration
> > TP_PROTO(struct inode *inode, struct page *page, unsigned long off, \
> > ^~~~~
>
> struct inode as well.
>
> So I'm not sure where the error is actually coming from, nor why it
> might only be generated by an obscure architecture (I've never heard
> of nds32 until now).
This looks like the magic code that ensures every header can be compiled
standalone. Which so far hasn't helped anything but caused tons of
pointless warnings.
That being said adding a couple struct forward declarations seems like
and easy way to shut it up here.
prev parent reply other threads:[~2019-09-10 6:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 15:52 [xfs-linux:iomap-for-next 3/12] include/trace/events/iomap.h:49:39: warning: 'struct page' declared inside parameter list will not be visible outside of this definition or declaration kbuild test robot
2019-09-08 21:38 ` Dave Chinner
2019-09-10 6:47 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190910064709.GA31448@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=kbuild-all@01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox