From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15106C4CEC7 for ; Thu, 12 Sep 2019 23:55:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E11972084D for ; Thu, 12 Sep 2019 23:55:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727448AbfILXzb (ORCPT ); Thu, 12 Sep 2019 19:55:31 -0400 Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:38383 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727325AbfILXzb (ORCPT ); Thu, 12 Sep 2019 19:55:31 -0400 Received: from dread.disaster.area (pa49-181-255-194.pa.nsw.optusnet.com.au [49.181.255.194]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 4DC3643E8CC; Fri, 13 Sep 2019 09:55:29 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.2) (envelope-from ) id 1i8Yvw-00083a-Ri; Fri, 13 Sep 2019 09:55:28 +1000 Date: Fri, 13 Sep 2019 09:55:28 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org Subject: Re: [PATCH 3/4] xfs_scrub: convert to per-ag inode bulkstat operations Message-ID: <20190912235528.GT16973@dread.disaster.area> References: <156774093859.2644581.13218735172589605186.stgit@magnolia> <156774096375.2644581.13727363113842017974.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <156774096375.2644581.13727363113842017974.stgit@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=FNpr/6gs c=1 sm=1 tr=0 a=YO9NNpcXwc8z/SaoS+iAiA==:117 a=YO9NNpcXwc8z/SaoS+iAiA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=J70Eh1EUuV4A:10 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=dFDqdkXLeZF3asbn4QMA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, Sep 05, 2019 at 08:36:03PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Now that we're done reworking the xfrog bulkstat wrapper functions, we > can adapt xfs_scrub to use the per-ag iteration functionality. > > Signed-off-by: Darrick J. Wong > --- > scrub/fscounters.c | 22 ++++++---------------- > scrub/inodes.c | 20 ++++++-------------- > 2 files changed, 12 insertions(+), 30 deletions(-) Nice simplification. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com