From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Brian Foster <bfoster@redhat.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: shortcut xfs_file_release for read-only file descriptors
Date: Wed, 18 Sep 2019 10:06:51 -0700 [thread overview]
Message-ID: <20190918170651.GY2229799@magnolia> (raw)
In-Reply-To: <20190918165000.GB19316@lst.de>
On Wed, Sep 18, 2019 at 06:50:00PM +0200, Christoph Hellwig wrote:
> On Mon, Sep 16, 2019 at 08:53:23AM -0400, Brian Foster wrote:
> > Didn't Dave have a variant of this patch for dealing with a
> > fragmentation issue (IIRC)? Anyways, seems fine:
>
> I don't really remember one. But maybe Dave can chime in.
He did[1], but IIRC the discussion petered out because we didn't have a
good way to measure the long term fragmentation effects of doing this.
I sent in a second patch[2] that only trimmed posteof blocks the first
time a file is closed, which reduced fragmentation dramatically on
workloads where there are a lot of synchronous open-append-close writes
(e.g. logging daemons).
None of that stuff ever got merged, so maybe it's time to revisit these.
--D
[1] https://lore.kernel.org/linux-xfs/20190207050813.24271-2-david@fromorbit.com/
[2] https://lore.kernel.org/linux-xfs/155259894034.30230.7188877605950498518.stgit@magnolia/
prev parent reply other threads:[~2019-09-18 17:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 12:20 minor ->release fixups and cleanups Christoph Hellwig
2019-09-16 12:20 ` [PATCH 1/2] xfs: remove xfs_release Christoph Hellwig
2019-09-16 12:53 ` Brian Foster
2019-09-18 16:49 ` Christoph Hellwig
2019-09-18 18:12 ` Brian Foster
2019-09-18 18:21 ` Darrick J. Wong
2019-09-18 22:25 ` Dave Chinner
2019-09-16 12:20 ` [PATCH 2/2] xfs: shortcut xfs_file_release for read-only file descriptors Christoph Hellwig
2019-09-16 12:53 ` Brian Foster
2019-09-18 16:50 ` Christoph Hellwig
2019-09-18 17:06 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918170651.GY2229799@magnolia \
--to=darrick.wong@oracle.com \
--cc=bfoster@redhat.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox