From: Zorro Lang <zlang@redhat.com>
To: fstests@vger.kernel.org
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH] common/xfs: wipe the XFS superblock of each AGs
Date: Thu, 19 Sep 2019 23:00:24 +0800 [thread overview]
Message-ID: <20190919150024.8346-1-zlang@redhat.com> (raw)
xfs/030 always fails after d0e484ac699f ("check: wipe scratch devices
between tests") get merged.
Due to xfs/030 does a sized(100m) mkfs. Before we merge above commit,
mkfs.xfs detects an old primary superblock, it will write zeroes to
all superblocks before formatting the new filesystem. But this won't
be done if we wipe the first superblock(by merging above commit).
That means if we make a (smaller) sized xfs after wipefs, those *old*
superblocks which created by last time mkfs.xfs will be left on disk.
Then when we do xfs_repair, if xfs_repair can't find the first SB, it
will go to find those *old* SB at first. When it finds them,
everyting goes wrong.
So I try to get XFS AG geometry(by default) and then try to erase all
superblocks. Thanks Darrick J. Wong helped to analyze this issue.
Signed-off-by: Zorro Lang <zlang@redhat.com>
---
common/rc | 4 ++++
common/xfs | 23 +++++++++++++++++++++++
2 files changed, 27 insertions(+)
diff --git a/common/rc b/common/rc
index 66c7fd4d..fe13f659 100644
--- a/common/rc
+++ b/common/rc
@@ -4048,6 +4048,10 @@ _try_wipe_scratch_devs()
for dev in $SCRATCH_DEV_POOL $SCRATCH_DEV $SCRATCH_LOGDEV $SCRATCH_RTDEV; do
test -b $dev && $WIPEFS_PROG -a $dev
done
+
+ if [ "$FSTYP" = "xfs" ];then
+ try_wipe_scratch_xfs
+ fi
}
# Only run this on xfs if xfs_scrub is available and has the unicode checker
diff --git a/common/xfs b/common/xfs
index 1bce3c18..34516f82 100644
--- a/common/xfs
+++ b/common/xfs
@@ -884,3 +884,26 @@ _xfs_mount_agcount()
{
$XFS_INFO_PROG "$1" | grep agcount= | sed -e 's/^.*agcount=\([0-9]*\),.*$/\1/g'
}
+
+# wipe the superblock of each XFS AGs
+try_wipe_scratch_xfs()
+{
+ local tmp=`mktemp -u`
+
+ _scratch_mkfs_xfs -N 2>/dev/null | perl -ne '
+ if (/^meta-data=.*\s+agcount=(\d+), agsize=(\d+) blks/) {
+ print STDOUT "agcount=$1\nagsize=$2\n";
+ }
+ if (/^data\s+=\s+bsize=(\d+)\s/) {
+ print STDOUT "dbsize=$1\n";
+ }' > $tmp.mkfs
+
+ . $tmp.mkfs
+ if [ -n "$agcount" -a -n "$agsize" -a -n "$dbsize" ];then
+ for ((i = 0; i < agcount; i++)); do
+ $XFS_IO_PROG -c "pwrite $((i * dbsize * agsize)) $dbsize" \
+ $SCRATCH_DEV >/dev/null;
+ done
+ fi
+ rm -f $tmp.mkfs
+}
--
2.20.1
next reply other threads:[~2019-09-19 15:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 15:00 Zorro Lang [this message]
2019-09-19 16:02 ` [PATCH] common/xfs: wipe the XFS superblock of each AGs Darrick J. Wong
2019-09-19 17:27 ` Zorro Lang
2019-09-20 1:52 ` Yang Xu
2019-09-20 2:48 ` Darrick J. Wong
2019-09-20 3:44 ` Yang Xu
2019-09-20 4:31 ` Zorro Lang
2019-09-20 4:29 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919150024.8346-1-zlang@redhat.com \
--to=zlang@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox