From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: log proper length of superblock
Date: Mon, 23 Sep 2019 16:48:35 -0700 [thread overview]
Message-ID: <20190923234835.GU2229799@magnolia> (raw)
In-Reply-To: <93a080c7-5eb8-8ffe-ae5b-5152a7713828@redhat.com>
On Mon, Sep 23, 2019 at 04:18:44PM -0500, Eric Sandeen wrote:
> xfs_trans_log_buf takes first byte, last byte as args. In this
> case, it should be from 0 to sizeof() - 1.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> I should have audited everything when I sent the last patch for
> this type of error. hch suggested changing the interface but it's
> all pretty grotty and I'm hesitant for now.
>
> I think maybe a new/separate function to take start, len might
> make sense so that not every caller needs to be munged into a new
> format, because some of the existing callers would then become more
> complex...
>
> diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c
> index a08dd8f40346..ac6cdca63e15 100644
> --- a/fs/xfs/libxfs/xfs_sb.c
> +++ b/fs/xfs/libxfs/xfs_sb.c
> @@ -928,7 +928,7 @@ xfs_log_sb(
>
> xfs_sb_to_disk(XFS_BUF_TO_SBP(bp), &mp->m_sb);
> xfs_trans_buf_set_type(tp, bp, XFS_BLFT_SB_BUF);
> - xfs_trans_log_buf(tp, bp, 0, sizeof(struct xfs_dsb));
> + xfs_trans_log_buf(tp, bp, 0, sizeof(struct xfs_dsb) - 1);
> }
>
> /*
>
prev parent reply other threads:[~2019-09-23 23:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 21:18 [PATCH] xfs: log proper length of superblock Eric Sandeen
2019-09-23 21:44 ` Eric Sandeen
2019-09-23 22:34 ` Dave Chinner
2019-09-23 23:48 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923234835.GU2229799@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox