From: Brian Foster <bfoster@redhat.com>
To: Ian Kent <raven@themaw.net>
Cc: linux-xfs <linux-xfs@vger.kernel.org>,
David Howells <dhowells@redhat.com>,
Dave Chinner <dchinner@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Eric Sandeen <sandeen@sandeen.net>
Subject: Re: [PATCH v3 02/16] xfs: remove very old mount option
Date: Tue, 24 Sep 2019 06:45:23 -0400 [thread overview]
Message-ID: <20190924104523.GD13820@bfoster> (raw)
In-Reply-To: <156897334377.20210.1896184598481042341.stgit@fedora-28>
On Fri, Sep 20, 2019 at 05:55:43PM +0800, Ian Kent wrote:
> It appears the biosize mount option hasn't been documented as
> a vilid option since 2005.
>
> So remove it.
>
> Signed-off-by: Ian Kent <raven@themaw.net>
> ---
Works for me:
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_super.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index f9450235533c..1010097354a6 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -51,7 +51,7 @@ static struct xfs_kobj xfs_dbg_kobj; /* global debug sysfs attrs */
> * Table driven mount option parser.
> */
> enum {
> - Opt_logbufs, Opt_logbsize, Opt_logdev, Opt_rtdev, Opt_biosize,
> + Opt_logbufs, Opt_logbsize, Opt_logdev, Opt_rtdev,
> Opt_wsync, Opt_noalign, Opt_swalloc, Opt_sunit, Opt_swidth, Opt_nouuid,
> Opt_grpid, Opt_nogrpid, Opt_bsdgroups, Opt_sysvgroups,
> Opt_allocsize, Opt_norecovery, Opt_inode64, Opt_inode32, Opt_ikeep,
> @@ -67,7 +67,6 @@ static const match_table_t tokens = {
> {Opt_logbsize, "logbsize=%s"}, /* size of XFS log buffers */
> {Opt_logdev, "logdev=%s"}, /* log device */
> {Opt_rtdev, "rtdev=%s"}, /* realtime I/O device */
> - {Opt_biosize, "biosize=%u"}, /* log2 of preferred buffered io size */
> {Opt_wsync, "wsync"}, /* safe-mode nfs compatible mount */
> {Opt_noalign, "noalign"}, /* turn off stripe alignment */
> {Opt_swalloc, "swalloc"}, /* turn on stripe width allocation */
> @@ -229,7 +228,6 @@ xfs_parseargs(
> return -ENOMEM;
> break;
> case Opt_allocsize:
> - case Opt_biosize:
> if (suffix_kstrtoint(args, 10, &iosize))
> return -EINVAL;
> iosizelog = ffs(iosize) - 1;
>
next prev parent reply other threads:[~2019-09-24 10:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 9:55 [PATCH v3 00/16] xfs: mount API patch series Ian Kent
2019-09-20 9:55 ` [PATCH v3 01/16] vfs: Create fs_context-aware mount_bdev() replacement Ian Kent
2019-09-20 9:55 ` [PATCH v3 02/16] xfs: remove very old mount option Ian Kent
2019-09-24 10:45 ` Brian Foster [this message]
2019-09-20 9:55 ` [PATCH v3 03/16] xfs: mount-api - add fs parameter description Ian Kent
2019-09-24 10:45 ` Brian Foster
2019-09-20 9:55 ` [PATCH v3 04/16] xfs: mount-api - refactor suffix_kstrtoint() Ian Kent
2019-09-24 10:46 ` Brian Foster
2019-09-20 9:55 ` [PATCH v3 05/16] xfs: mount-api - refactor xfs_parseags() Ian Kent
2019-09-24 10:46 ` Brian Foster
2019-09-20 9:56 ` [PATCH v3 06/16] xfs: mount-api - make xfs_parse_param() take context .parse_param() args Ian Kent
2019-09-24 10:54 ` Brian Foster
2019-09-24 11:00 ` Ian Kent
2019-09-20 9:56 ` [PATCH v3 07/16] xfs: mount-api - move xfs_parseargs() validation to a helper Ian Kent
2019-09-24 10:56 ` Brian Foster
2019-09-24 11:41 ` Ian Kent
2019-09-20 9:56 ` [PATCH v3 08/16] xfs: mount-api - refactor xfs_fs_fill_super() Ian Kent
2019-09-20 9:56 ` [PATCH v3 09/16] xfs: mount-api - add xfs_get_tree() Ian Kent
2019-09-20 9:56 ` [PATCH v3 10/16] xfs: mount-api - add xfs_remount_rw() helper Ian Kent
2019-09-20 9:56 ` [PATCH v3 11/16] xfs: mount-api - add xfs_remount_ro() helper Ian Kent
2019-09-20 9:56 ` [PATCH v3 12/16] xfs: mount api - add xfs_reconfigure() Ian Kent
2019-09-20 9:56 ` [PATCH v3 13/16] xfs: mount-api - add xfs_fc_free() Ian Kent
2019-09-20 9:56 ` [PATCH v3 14/16] xfs: mount-api - dont set sb in xfs_mount_alloc() Ian Kent
2019-09-20 9:56 ` [PATCH v3 15/16] xfs: mount-api - switch to new mount-api Ian Kent
2019-09-20 9:56 ` [PATCH v3 16/16] xfs: mount-api - remove legacy mount functions Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190924104523.GD13820@bfoster \
--to=bfoster@redhat.com \
--cc=dchinner@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=raven@themaw.net \
--cc=sandeen@sandeen.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox