From: Brian Foster <bfoster@redhat.com>
To: Ian Kent <raven@themaw.net>
Cc: linux-xfs <linux-xfs@vger.kernel.org>,
David Howells <dhowells@redhat.com>,
Dave Chinner <dchinner@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Eric Sandeen <sandeen@sandeen.net>
Subject: Re: [PATCH v3 05/16] xfs: mount-api - refactor xfs_parseags()
Date: Tue, 24 Sep 2019 06:46:20 -0400 [thread overview]
Message-ID: <20190924104620.GG13820@bfoster> (raw)
In-Reply-To: <156897335938.20210.4456134010246885528.stgit@fedora-28>
On Fri, Sep 20, 2019 at 05:55:59PM +0800, Ian Kent wrote:
> Refactor xfs_parseags(), move the entire token case block to a
> separate function in an attempt to highlight the code that
> actually changes in converting to use the new mount api.
>
> The only changes are what's needed to communicate the variables
> dsunit, dswidth and iosizelog back to xfs_parseags().
>
> Signed-off-by: Ian Kent <raven@themaw.net>
> ---
No changes from the previous version except for the lack of the bio size
options. There's probably no need to drop the r-b tag for that:
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_super.c | 290 ++++++++++++++++++++++++++++------------------------
> 1 file changed, 155 insertions(+), 135 deletions(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 6a16750b1314..b04aebab69ab 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -205,6 +205,156 @@ match_kstrtoint(const substring_t *s, unsigned int base, int *res)
> return ret;
> }
>
> +STATIC int
> +xfs_parse_param(
> + int token,
> + char *p,
> + substring_t *args,
> + struct xfs_mount *mp,
> + int *dsunit,
> + int *dswidth,
> + uint8_t *iosizelog)
> +{
> + int iosize = 0;
> +
> + switch (token) {
> + case Opt_logbufs:
> + if (match_int(args, &mp->m_logbufs))
> + return -EINVAL;
> + break;
> + case Opt_logbsize:
> + if (match_kstrtoint(args, 10, &mp->m_logbsize))
> + return -EINVAL;
> + break;
> + case Opt_logdev:
> + kfree(mp->m_logname);
> + mp->m_logname = match_strdup(args);
> + if (!mp->m_logname)
> + return -ENOMEM;
> + break;
> + case Opt_rtdev:
> + kfree(mp->m_rtname);
> + mp->m_rtname = match_strdup(args);
> + if (!mp->m_rtname)
> + return -ENOMEM;
> + break;
> + case Opt_allocsize:
> + if (match_kstrtoint(args, 10, &iosize))
> + return -EINVAL;
> + *iosizelog = ffs(iosize) - 1;
> + break;
> + case Opt_grpid:
> + case Opt_bsdgroups:
> + mp->m_flags |= XFS_MOUNT_GRPID;
> + break;
> + case Opt_nogrpid:
> + case Opt_sysvgroups:
> + mp->m_flags &= ~XFS_MOUNT_GRPID;
> + break;
> + case Opt_wsync:
> + mp->m_flags |= XFS_MOUNT_WSYNC;
> + break;
> + case Opt_norecovery:
> + mp->m_flags |= XFS_MOUNT_NORECOVERY;
> + break;
> + case Opt_noalign:
> + mp->m_flags |= XFS_MOUNT_NOALIGN;
> + break;
> + case Opt_swalloc:
> + mp->m_flags |= XFS_MOUNT_SWALLOC;
> + break;
> + case Opt_sunit:
> + if (match_int(args, dsunit))
> + return -EINVAL;
> + break;
> + case Opt_swidth:
> + if (match_int(args, dswidth))
> + return -EINVAL;
> + break;
> + case Opt_inode32:
> + mp->m_flags |= XFS_MOUNT_SMALL_INUMS;
> + break;
> + case Opt_inode64:
> + mp->m_flags &= ~XFS_MOUNT_SMALL_INUMS;
> + break;
> + case Opt_nouuid:
> + mp->m_flags |= XFS_MOUNT_NOUUID;
> + break;
> + case Opt_ikeep:
> + mp->m_flags |= XFS_MOUNT_IKEEP;
> + break;
> + case Opt_noikeep:
> + mp->m_flags &= ~XFS_MOUNT_IKEEP;
> + break;
> + case Opt_largeio:
> + mp->m_flags &= ~XFS_MOUNT_COMPAT_IOSIZE;
> + break;
> + case Opt_nolargeio:
> + mp->m_flags |= XFS_MOUNT_COMPAT_IOSIZE;
> + break;
> + case Opt_attr2:
> + mp->m_flags |= XFS_MOUNT_ATTR2;
> + break;
> + case Opt_noattr2:
> + mp->m_flags &= ~XFS_MOUNT_ATTR2;
> + mp->m_flags |= XFS_MOUNT_NOATTR2;
> + break;
> + case Opt_filestreams:
> + mp->m_flags |= XFS_MOUNT_FILESTREAMS;
> + break;
> + case Opt_noquota:
> + mp->m_qflags &= ~XFS_ALL_QUOTA_ACCT;
> + mp->m_qflags &= ~XFS_ALL_QUOTA_ENFD;
> + mp->m_qflags &= ~XFS_ALL_QUOTA_ACTIVE;
> + break;
> + case Opt_quota:
> + case Opt_uquota:
> + case Opt_usrquota:
> + mp->m_qflags |= (XFS_UQUOTA_ACCT | XFS_UQUOTA_ACTIVE |
> + XFS_UQUOTA_ENFD);
> + break;
> + case Opt_qnoenforce:
> + case Opt_uqnoenforce:
> + mp->m_qflags |= (XFS_UQUOTA_ACCT | XFS_UQUOTA_ACTIVE);
> + mp->m_qflags &= ~XFS_UQUOTA_ENFD;
> + break;
> + case Opt_pquota:
> + case Opt_prjquota:
> + mp->m_qflags |= (XFS_PQUOTA_ACCT | XFS_PQUOTA_ACTIVE |
> + XFS_PQUOTA_ENFD);
> + break;
> + case Opt_pqnoenforce:
> + mp->m_qflags |= (XFS_PQUOTA_ACCT | XFS_PQUOTA_ACTIVE);
> + mp->m_qflags &= ~XFS_PQUOTA_ENFD;
> + break;
> + case Opt_gquota:
> + case Opt_grpquota:
> + mp->m_qflags |= (XFS_GQUOTA_ACCT | XFS_GQUOTA_ACTIVE |
> + XFS_GQUOTA_ENFD);
> + break;
> + case Opt_gqnoenforce:
> + mp->m_qflags |= (XFS_GQUOTA_ACCT | XFS_GQUOTA_ACTIVE);
> + mp->m_qflags &= ~XFS_GQUOTA_ENFD;
> + break;
> + case Opt_discard:
> + mp->m_flags |= XFS_MOUNT_DISCARD;
> + break;
> + case Opt_nodiscard:
> + mp->m_flags &= ~XFS_MOUNT_DISCARD;
> + break;
> +#ifdef CONFIG_FS_DAX
> + case Opt_dax:
> + mp->m_flags |= XFS_MOUNT_DAX;
> + break;
> +#endif
> + default:
> + xfs_warn(mp, "unknown mount option [%s].", p);
> + return -EINVAL;
> + }
> +
> + return 0;
> +}
> +
> /*
> * This function fills in xfs_mount_t fields based on mount args.
> * Note: the superblock has _not_ yet been read in.
> @@ -226,7 +376,6 @@ xfs_parseargs(
> substring_t args[MAX_OPT_ARGS];
> int dsunit = 0;
> int dswidth = 0;
> - int iosize = 0;
> uint8_t iosizelog = 0;
>
> /*
> @@ -265,145 +414,16 @@ xfs_parseargs(
>
> while ((p = strsep(&options, ",")) != NULL) {
> int token;
> + int ret;
>
> if (!*p)
> continue;
>
> token = match_token(p, tokens, args);
> - switch (token) {
> - case Opt_logbufs:
> - if (match_int(args, &mp->m_logbufs))
> - return -EINVAL;
> - break;
> - case Opt_logbsize:
> - if (match_kstrtoint(args, 10, &mp->m_logbsize))
> - return -EINVAL;
> - break;
> - case Opt_logdev:
> - kfree(mp->m_logname);
> - mp->m_logname = match_strdup(args);
> - if (!mp->m_logname)
> - return -ENOMEM;
> - break;
> - case Opt_rtdev:
> - kfree(mp->m_rtname);
> - mp->m_rtname = match_strdup(args);
> - if (!mp->m_rtname)
> - return -ENOMEM;
> - break;
> - case Opt_allocsize:
> - if (match_kstrtoint(args, 10, &iosize))
> - return -EINVAL;
> - iosizelog = ffs(iosize) - 1;
> - break;
> - case Opt_grpid:
> - case Opt_bsdgroups:
> - mp->m_flags |= XFS_MOUNT_GRPID;
> - break;
> - case Opt_nogrpid:
> - case Opt_sysvgroups:
> - mp->m_flags &= ~XFS_MOUNT_GRPID;
> - break;
> - case Opt_wsync:
> - mp->m_flags |= XFS_MOUNT_WSYNC;
> - break;
> - case Opt_norecovery:
> - mp->m_flags |= XFS_MOUNT_NORECOVERY;
> - break;
> - case Opt_noalign:
> - mp->m_flags |= XFS_MOUNT_NOALIGN;
> - break;
> - case Opt_swalloc:
> - mp->m_flags |= XFS_MOUNT_SWALLOC;
> - break;
> - case Opt_sunit:
> - if (match_int(args, &dsunit))
> - return -EINVAL;
> - break;
> - case Opt_swidth:
> - if (match_int(args, &dswidth))
> - return -EINVAL;
> - break;
> - case Opt_inode32:
> - mp->m_flags |= XFS_MOUNT_SMALL_INUMS;
> - break;
> - case Opt_inode64:
> - mp->m_flags &= ~XFS_MOUNT_SMALL_INUMS;
> - break;
> - case Opt_nouuid:
> - mp->m_flags |= XFS_MOUNT_NOUUID;
> - break;
> - case Opt_ikeep:
> - mp->m_flags |= XFS_MOUNT_IKEEP;
> - break;
> - case Opt_noikeep:
> - mp->m_flags &= ~XFS_MOUNT_IKEEP;
> - break;
> - case Opt_largeio:
> - mp->m_flags &= ~XFS_MOUNT_COMPAT_IOSIZE;
> - break;
> - case Opt_nolargeio:
> - mp->m_flags |= XFS_MOUNT_COMPAT_IOSIZE;
> - break;
> - case Opt_attr2:
> - mp->m_flags |= XFS_MOUNT_ATTR2;
> - break;
> - case Opt_noattr2:
> - mp->m_flags &= ~XFS_MOUNT_ATTR2;
> - mp->m_flags |= XFS_MOUNT_NOATTR2;
> - break;
> - case Opt_filestreams:
> - mp->m_flags |= XFS_MOUNT_FILESTREAMS;
> - break;
> - case Opt_noquota:
> - mp->m_qflags &= ~XFS_ALL_QUOTA_ACCT;
> - mp->m_qflags &= ~XFS_ALL_QUOTA_ENFD;
> - mp->m_qflags &= ~XFS_ALL_QUOTA_ACTIVE;
> - break;
> - case Opt_quota:
> - case Opt_uquota:
> - case Opt_usrquota:
> - mp->m_qflags |= (XFS_UQUOTA_ACCT | XFS_UQUOTA_ACTIVE |
> - XFS_UQUOTA_ENFD);
> - break;
> - case Opt_qnoenforce:
> - case Opt_uqnoenforce:
> - mp->m_qflags |= (XFS_UQUOTA_ACCT | XFS_UQUOTA_ACTIVE);
> - mp->m_qflags &= ~XFS_UQUOTA_ENFD;
> - break;
> - case Opt_pquota:
> - case Opt_prjquota:
> - mp->m_qflags |= (XFS_PQUOTA_ACCT | XFS_PQUOTA_ACTIVE |
> - XFS_PQUOTA_ENFD);
> - break;
> - case Opt_pqnoenforce:
> - mp->m_qflags |= (XFS_PQUOTA_ACCT | XFS_PQUOTA_ACTIVE);
> - mp->m_qflags &= ~XFS_PQUOTA_ENFD;
> - break;
> - case Opt_gquota:
> - case Opt_grpquota:
> - mp->m_qflags |= (XFS_GQUOTA_ACCT | XFS_GQUOTA_ACTIVE |
> - XFS_GQUOTA_ENFD);
> - break;
> - case Opt_gqnoenforce:
> - mp->m_qflags |= (XFS_GQUOTA_ACCT | XFS_GQUOTA_ACTIVE);
> - mp->m_qflags &= ~XFS_GQUOTA_ENFD;
> - break;
> - case Opt_discard:
> - mp->m_flags |= XFS_MOUNT_DISCARD;
> - break;
> - case Opt_nodiscard:
> - mp->m_flags &= ~XFS_MOUNT_DISCARD;
> - break;
> -#ifdef CONFIG_FS_DAX
> - case Opt_dax:
> - mp->m_flags |= XFS_MOUNT_DAX;
> - break;
> -#endif
> - default:
> - xfs_warn(mp, "unknown mount option [%s].", p);
> - return -EINVAL;
> - }
> + ret = xfs_parse_param(token, p, args, mp,
> + &dsunit, &dswidth, &iosizelog);
> + if (ret)
> + return ret;
> }
>
> /*
>
next prev parent reply other threads:[~2019-09-24 10:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 9:55 [PATCH v3 00/16] xfs: mount API patch series Ian Kent
2019-09-20 9:55 ` [PATCH v3 01/16] vfs: Create fs_context-aware mount_bdev() replacement Ian Kent
2019-09-20 9:55 ` [PATCH v3 02/16] xfs: remove very old mount option Ian Kent
2019-09-24 10:45 ` Brian Foster
2019-09-20 9:55 ` [PATCH v3 03/16] xfs: mount-api - add fs parameter description Ian Kent
2019-09-24 10:45 ` Brian Foster
2019-09-20 9:55 ` [PATCH v3 04/16] xfs: mount-api - refactor suffix_kstrtoint() Ian Kent
2019-09-24 10:46 ` Brian Foster
2019-09-20 9:55 ` [PATCH v3 05/16] xfs: mount-api - refactor xfs_parseags() Ian Kent
2019-09-24 10:46 ` Brian Foster [this message]
2019-09-20 9:56 ` [PATCH v3 06/16] xfs: mount-api - make xfs_parse_param() take context .parse_param() args Ian Kent
2019-09-24 10:54 ` Brian Foster
2019-09-24 11:00 ` Ian Kent
2019-09-20 9:56 ` [PATCH v3 07/16] xfs: mount-api - move xfs_parseargs() validation to a helper Ian Kent
2019-09-24 10:56 ` Brian Foster
2019-09-24 11:41 ` Ian Kent
2019-09-20 9:56 ` [PATCH v3 08/16] xfs: mount-api - refactor xfs_fs_fill_super() Ian Kent
2019-09-20 9:56 ` [PATCH v3 09/16] xfs: mount-api - add xfs_get_tree() Ian Kent
2019-09-20 9:56 ` [PATCH v3 10/16] xfs: mount-api - add xfs_remount_rw() helper Ian Kent
2019-09-20 9:56 ` [PATCH v3 11/16] xfs: mount-api - add xfs_remount_ro() helper Ian Kent
2019-09-20 9:56 ` [PATCH v3 12/16] xfs: mount api - add xfs_reconfigure() Ian Kent
2019-09-20 9:56 ` [PATCH v3 13/16] xfs: mount-api - add xfs_fc_free() Ian Kent
2019-09-20 9:56 ` [PATCH v3 14/16] xfs: mount-api - dont set sb in xfs_mount_alloc() Ian Kent
2019-09-20 9:56 ` [PATCH v3 15/16] xfs: mount-api - switch to new mount-api Ian Kent
2019-09-20 9:56 ` [PATCH v3 16/16] xfs: mount-api - remove legacy mount functions Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190924104620.GG13820@bfoster \
--to=bfoster@redhat.com \
--cc=dchinner@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=raven@themaw.net \
--cc=sandeen@sandeen.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox