From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A0EBC432C2 for ; Wed, 25 Sep 2019 23:11:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D60F321D7B for ; Wed, 25 Sep 2019 23:11:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569453111; bh=KJHLUbB8SYBsc/KJZv2Kap+YtlGIWW9oxeHInMhCeT4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=xrwQnOUyPKjZ9Q8XtFuWhkYpMqRPgRigftqgCosgd4kTQaVE+9RPVkeSbGO7wIlls /GjQRkjjqZ+FkhvijiWQcEtd3XineWwaGBbWu+hNO+ytUZ4USkecyv97dOMHOatOw0 6AjYs14WiSReyrE8z4OqZpVJuFUlw9zYfeHsL4TA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727055AbfIYXLu (ORCPT ); Wed, 25 Sep 2019 19:11:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:57200 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725821AbfIYXLu (ORCPT ); Wed, 25 Sep 2019 19:11:50 -0400 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 84B3C20640; Wed, 25 Sep 2019 23:11:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569453109; bh=KJHLUbB8SYBsc/KJZv2Kap+YtlGIWW9oxeHInMhCeT4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uZExk2+w0NqhBLiHq5L0Pl6chNBlF8UBiqxK44QzsKuJbXRLTkTiRJhFQzG5hDEXW GPR3uf0ZTBcw3ShD4prjSxhW9APbVf3qSWVgEUAdGhv4D2A99Gllbbi1TIN3VudDCm udx+osGEeiUJyYQn05WiJNj2ITRhZY/zM12rjJMk= Date: Wed, 25 Sep 2019 16:11:48 -0700 From: Eric Biggers To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, linux-fscrypt@vger.kernel.org Subject: Re: [RFC PATCH 3/8] xfs_io/encrypt: add new encryption modes Message-ID: <20190925231147.GB3163@gmail.com> Mail-Followup-To: "Darrick J. Wong" , linux-xfs@vger.kernel.org, fstests@vger.kernel.org, linux-fscrypt@vger.kernel.org References: <20190812175635.34186-1-ebiggers@kernel.org> <20190812175635.34186-4-ebiggers@kernel.org> <20190924224744.GD2229799@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190924224744.GD2229799@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Sep 24, 2019 at 03:47:44PM -0700, Darrick J. Wong wrote: > On Mon, Aug 12, 2019 at 10:56:29AM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > Add new encryption modes: AES-128-CBC and AES-128-CTS (supported since > > Linux v4.11), and Adiantum (supported since Linux v5.0). > > > > Signed-off-by: Eric Biggers > > --- > > io/encrypt.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/io/encrypt.c b/io/encrypt.c > > index ac473ed7..11eb4a3e 100644 > > --- a/io/encrypt.c > > +++ b/io/encrypt.c > > @@ -156,7 +156,7 @@ set_encpolicy_help(void) > > " -v VERSION -- version of policy structure\n" > > "\n" > > " MODE can be numeric or one of the following predefined values:\n" > > -" AES-256-XTS, AES-256-CTS\n" > > +" AES-256-XTS, AES-256-CTS, AES-128-CBC, AES-128-CTS, Adiantum\n" > > What do you think of generating the list of predefined values from > the available_modes[] array? Then you wouldn't have to keep the help > text in sync with the C definitions, since it's not like there's a > meaningful translation for them anyway. > Yes, good idea. I'll do that. - Eric