* [PATCH] xfs: removed unused error variable from xchk_refcountbt_rec
@ 2019-09-30 13:58 Aliasgar Surti
2019-09-30 17:04 ` Brian Foster
2019-09-30 18:24 ` Darrick J. Wong
0 siblings, 2 replies; 3+ messages in thread
From: Aliasgar Surti @ 2019-09-30 13:58 UTC (permalink / raw)
To: darrick.wong, linux-xfs, bfoster; +Cc: Aliasgar Surti
From: Aliasgar Surti <aliasgar.surti500@gmail.com>
Removed unused error variable. Instead of using error variable,
returned the value directly as it wasn't updated.
Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
---
fs/xfs/scrub/refcount.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/xfs/scrub/refcount.c b/fs/xfs/scrub/refcount.c
index 93b3793b..0cab11a 100644
--- a/fs/xfs/scrub/refcount.c
+++ b/fs/xfs/scrub/refcount.c
@@ -341,7 +341,6 @@ xchk_refcountbt_rec(
xfs_extlen_t len;
xfs_nlink_t refcount;
bool has_cowflag;
- int error = 0;
bno = be32_to_cpu(rec->refc.rc_startblock);
len = be32_to_cpu(rec->refc.rc_blockcount);
@@ -366,7 +365,7 @@ xchk_refcountbt_rec(
xchk_refcountbt_xref(bs->sc, bno, len, refcount);
- return error;
+ return 0;
}
/* Make sure we have as many refc blocks as the rmap says. */
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: removed unused error variable from xchk_refcountbt_rec
2019-09-30 13:58 [PATCH] xfs: removed unused error variable from xchk_refcountbt_rec Aliasgar Surti
@ 2019-09-30 17:04 ` Brian Foster
2019-09-30 18:24 ` Darrick J. Wong
1 sibling, 0 replies; 3+ messages in thread
From: Brian Foster @ 2019-09-30 17:04 UTC (permalink / raw)
To: Aliasgar Surti; +Cc: darrick.wong, linux-xfs
On Mon, Sep 30, 2019 at 07:28:54PM +0530, Aliasgar Surti wrote:
> From: Aliasgar Surti <aliasgar.surti500@gmail.com>
>
> Removed unused error variable. Instead of using error variable,
> returned the value directly as it wasn't updated.
>
> Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/scrub/refcount.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/xfs/scrub/refcount.c b/fs/xfs/scrub/refcount.c
> index 93b3793b..0cab11a 100644
> --- a/fs/xfs/scrub/refcount.c
> +++ b/fs/xfs/scrub/refcount.c
> @@ -341,7 +341,6 @@ xchk_refcountbt_rec(
> xfs_extlen_t len;
> xfs_nlink_t refcount;
> bool has_cowflag;
> - int error = 0;
>
> bno = be32_to_cpu(rec->refc.rc_startblock);
> len = be32_to_cpu(rec->refc.rc_blockcount);
> @@ -366,7 +365,7 @@ xchk_refcountbt_rec(
>
> xchk_refcountbt_xref(bs->sc, bno, len, refcount);
>
> - return error;
> + return 0;
> }
>
> /* Make sure we have as many refc blocks as the rmap says. */
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: removed unused error variable from xchk_refcountbt_rec
2019-09-30 13:58 [PATCH] xfs: removed unused error variable from xchk_refcountbt_rec Aliasgar Surti
2019-09-30 17:04 ` Brian Foster
@ 2019-09-30 18:24 ` Darrick J. Wong
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2019-09-30 18:24 UTC (permalink / raw)
To: Aliasgar Surti; +Cc: linux-xfs, bfoster
On Mon, Sep 30, 2019 at 07:28:54PM +0530, Aliasgar Surti wrote:
> From: Aliasgar Surti <aliasgar.surti500@gmail.com>
>
> Removed unused error variable. Instead of using error variable,
> returned the value directly as it wasn't updated.
>
> Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/scrub/refcount.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/xfs/scrub/refcount.c b/fs/xfs/scrub/refcount.c
> index 93b3793b..0cab11a 100644
> --- a/fs/xfs/scrub/refcount.c
> +++ b/fs/xfs/scrub/refcount.c
> @@ -341,7 +341,6 @@ xchk_refcountbt_rec(
> xfs_extlen_t len;
> xfs_nlink_t refcount;
> bool has_cowflag;
> - int error = 0;
>
> bno = be32_to_cpu(rec->refc.rc_startblock);
> len = be32_to_cpu(rec->refc.rc_blockcount);
> @@ -366,7 +365,7 @@ xchk_refcountbt_rec(
>
> xchk_refcountbt_xref(bs->sc, bno, len, refcount);
>
> - return error;
> + return 0;
> }
>
> /* Make sure we have as many refc blocks as the rmap says. */
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-30 20:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-30 13:58 [PATCH] xfs: removed unused error variable from xchk_refcountbt_rec Aliasgar Surti
2019-09-30 17:04 ` Brian Foster
2019-09-30 18:24 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).