From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: remove unused flags arg from xfs_get_aghdr_buf()
Date: Mon, 30 Sep 2019 11:24:41 -0700 [thread overview]
Message-ID: <20190930182441.GD13108@magnolia> (raw)
In-Reply-To: <2f4d86a1-0cb9-f859-b120-34d1b511942f@redhat.com>
On Fri, Sep 27, 2019 at 10:46:42AM -0500, Eric Sandeen wrote:
> The flags op is always passed as zero, so remove it.
>
> (xfs_buf_get_uncached takes flags to support XBF_NO_IOACCT for
> the sb, but that should never be relevant for xfs_get_aghdr_buf)
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> diff --git a/fs/xfs/libxfs/xfs_ag.c b/fs/xfs/libxfs/xfs_ag.c
> index 5de296b34ab1..14fbdf22b7e7 100644
> --- a/fs/xfs/libxfs/xfs_ag.c
> +++ b/fs/xfs/libxfs/xfs_ag.c
> @@ -28,12 +28,11 @@ xfs_get_aghdr_buf(
> struct xfs_mount *mp,
> xfs_daddr_t blkno,
> size_t numblks,
> - int flags,
> const struct xfs_buf_ops *ops)
> {
> struct xfs_buf *bp;
>
> - bp = xfs_buf_get_uncached(mp->m_ddev_targp, numblks, flags);
> + bp = xfs_buf_get_uncached(mp->m_ddev_targp, numblks, 0);
> if (!bp)
> return NULL;
>
> @@ -345,7 +344,7 @@ xfs_ag_init_hdr(
> {
> struct xfs_buf *bp;
>
> - bp = xfs_get_aghdr_buf(mp, id->daddr, id->numblks, 0, ops);
> + bp = xfs_get_aghdr_buf(mp, id->daddr, id->numblks, ops);
> if (!bp)
> return -ENOMEM;
>
>
prev parent reply other threads:[~2019-09-30 21:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 15:46 [PATCH] xfs: remove unused flags arg from xfs_get_aghdr_buf() Eric Sandeen
2019-09-27 15:50 ` Eric Sandeen
2019-09-30 7:38 ` Carlos Maiolino
2019-09-30 7:42 ` Christoph Hellwig
2019-09-30 18:24 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930182441.GD13108@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).