* Re: [PATCH] xfs: remove unused flags arg from xfs_get_aghdr_buf()
2019-09-27 15:46 [PATCH] xfs: remove unused flags arg from xfs_get_aghdr_buf() Eric Sandeen
@ 2019-09-27 15:50 ` Eric Sandeen
2019-09-30 7:38 ` Carlos Maiolino
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Eric Sandeen @ 2019-09-27 15:50 UTC (permalink / raw)
To: Eric Sandeen, linux-xfs
On 9/27/19 10:46 AM, Eric Sandeen wrote:
> The flags op is always passed as zero, so remove it.
Argh. "arg"
-Eric
> (xfs_buf_get_uncached takes flags to support XBF_NO_IOACCT for
> the sb, but that should never be relevant for xfs_get_aghdr_buf)
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/fs/xfs/libxfs/xfs_ag.c b/fs/xfs/libxfs/xfs_ag.c
> index 5de296b34ab1..14fbdf22b7e7 100644
> --- a/fs/xfs/libxfs/xfs_ag.c
> +++ b/fs/xfs/libxfs/xfs_ag.c
> @@ -28,12 +28,11 @@ xfs_get_aghdr_buf(
> struct xfs_mount *mp,
> xfs_daddr_t blkno,
> size_t numblks,
> - int flags,
> const struct xfs_buf_ops *ops)
> {
> struct xfs_buf *bp;
>
> - bp = xfs_buf_get_uncached(mp->m_ddev_targp, numblks, flags);
> + bp = xfs_buf_get_uncached(mp->m_ddev_targp, numblks, 0);
> if (!bp)
> return NULL;
>
> @@ -345,7 +344,7 @@ xfs_ag_init_hdr(
> {
> struct xfs_buf *bp;
>
> - bp = xfs_get_aghdr_buf(mp, id->daddr, id->numblks, 0, ops);
> + bp = xfs_get_aghdr_buf(mp, id->daddr, id->numblks, ops);
> if (!bp)
> return -ENOMEM;
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] xfs: remove unused flags arg from xfs_get_aghdr_buf()
2019-09-27 15:46 [PATCH] xfs: remove unused flags arg from xfs_get_aghdr_buf() Eric Sandeen
2019-09-27 15:50 ` Eric Sandeen
@ 2019-09-30 7:38 ` Carlos Maiolino
2019-09-30 7:42 ` Christoph Hellwig
2019-09-30 18:24 ` Darrick J. Wong
3 siblings, 0 replies; 5+ messages in thread
From: Carlos Maiolino @ 2019-09-30 7:38 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Fri, Sep 27, 2019 at 10:46:42AM -0500, Eric Sandeen wrote:
> The flags op is always passed as zero, so remove it.
Fixing the op -> arg:
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
>
> (xfs_buf_get_uncached takes flags to support XBF_NO_IOACCT for
> the sb, but that should never be relevant for xfs_get_aghdr_buf)
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/fs/xfs/libxfs/xfs_ag.c b/fs/xfs/libxfs/xfs_ag.c
> index 5de296b34ab1..14fbdf22b7e7 100644
> --- a/fs/xfs/libxfs/xfs_ag.c
> +++ b/fs/xfs/libxfs/xfs_ag.c
> @@ -28,12 +28,11 @@ xfs_get_aghdr_buf(
> struct xfs_mount *mp,
> xfs_daddr_t blkno,
> size_t numblks,
> - int flags,
> const struct xfs_buf_ops *ops)
> {
> struct xfs_buf *bp;
>
> - bp = xfs_buf_get_uncached(mp->m_ddev_targp, numblks, flags);
> + bp = xfs_buf_get_uncached(mp->m_ddev_targp, numblks, 0);
> if (!bp)
> return NULL;
>
> @@ -345,7 +344,7 @@ xfs_ag_init_hdr(
> {
> struct xfs_buf *bp;
>
> - bp = xfs_get_aghdr_buf(mp, id->daddr, id->numblks, 0, ops);
> + bp = xfs_get_aghdr_buf(mp, id->daddr, id->numblks, ops);
> if (!bp)
> return -ENOMEM;
>
>
--
Carlos
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] xfs: remove unused flags arg from xfs_get_aghdr_buf()
2019-09-27 15:46 [PATCH] xfs: remove unused flags arg from xfs_get_aghdr_buf() Eric Sandeen
2019-09-27 15:50 ` Eric Sandeen
2019-09-30 7:38 ` Carlos Maiolino
@ 2019-09-30 7:42 ` Christoph Hellwig
2019-09-30 18:24 ` Darrick J. Wong
3 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2019-09-30 7:42 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Fri, Sep 27, 2019 at 10:46:42AM -0500, Eric Sandeen wrote:
> The flags op is always passed as zero, so remove it.
>
> (xfs_buf_get_uncached takes flags to support XBF_NO_IOACCT for
> the sb, but that should never be relevant for xfs_get_aghdr_buf)
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs: remove unused flags arg from xfs_get_aghdr_buf()
2019-09-27 15:46 [PATCH] xfs: remove unused flags arg from xfs_get_aghdr_buf() Eric Sandeen
` (2 preceding siblings ...)
2019-09-30 7:42 ` Christoph Hellwig
@ 2019-09-30 18:24 ` Darrick J. Wong
3 siblings, 0 replies; 5+ messages in thread
From: Darrick J. Wong @ 2019-09-30 18:24 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Fri, Sep 27, 2019 at 10:46:42AM -0500, Eric Sandeen wrote:
> The flags op is always passed as zero, so remove it.
>
> (xfs_buf_get_uncached takes flags to support XBF_NO_IOACCT for
> the sb, but that should never be relevant for xfs_get_aghdr_buf)
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> diff --git a/fs/xfs/libxfs/xfs_ag.c b/fs/xfs/libxfs/xfs_ag.c
> index 5de296b34ab1..14fbdf22b7e7 100644
> --- a/fs/xfs/libxfs/xfs_ag.c
> +++ b/fs/xfs/libxfs/xfs_ag.c
> @@ -28,12 +28,11 @@ xfs_get_aghdr_buf(
> struct xfs_mount *mp,
> xfs_daddr_t blkno,
> size_t numblks,
> - int flags,
> const struct xfs_buf_ops *ops)
> {
> struct xfs_buf *bp;
>
> - bp = xfs_buf_get_uncached(mp->m_ddev_targp, numblks, flags);
> + bp = xfs_buf_get_uncached(mp->m_ddev_targp, numblks, 0);
> if (!bp)
> return NULL;
>
> @@ -345,7 +344,7 @@ xfs_ag_init_hdr(
> {
> struct xfs_buf *bp;
>
> - bp = xfs_get_aghdr_buf(mp, id->daddr, id->numblks, 0, ops);
> + bp = xfs_get_aghdr_buf(mp, id->daddr, id->numblks, ops);
> if (!bp)
> return -ENOMEM;
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread