public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [RFC PATCH 1/3] xfs: temporarily bypass oneshot grant tail verification
Date: Mon, 14 Oct 2019 14:12:58 -0400	[thread overview]
Message-ID: <20191014181300.15494-2-bfoster@redhat.com> (raw)
In-Reply-To: <20191014181300.15494-1-bfoster@redhat.com>

Temporary hack to xlog_verify_grant_tail() to never set the
XLOG_TAIL_WARN oneshot warning flag. This results in a warning for
each instance of grant reservation tail overrun. For experimental
purposes only.

Not-signed-off-by: Brian Foster <bfoster@redhat.com>
---
 fs/xfs/xfs_log.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
index 641d07f30a27..045ab648ca96 100644
--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -3742,15 +3742,17 @@ xlog_verify_grant_tail(
 		if (cycle - 1 != tail_cycle &&
 		    !(log->l_flags & XLOG_TAIL_WARN)) {
 			xfs_alert_tag(log->l_mp, XFS_PTAG_LOGRES,
-				"%s: cycle - 1 != tail_cycle", __func__);
-			log->l_flags |= XLOG_TAIL_WARN;
+				"%s: cycle - 1 (%d) != tail_cycle (%d)",
+				__func__, cycle - 1, tail_cycle);
+			//log->l_flags |= XLOG_TAIL_WARN;
+			return;
 		}
 
 		if (space > BBTOB(tail_blocks) &&
 		    !(log->l_flags & XLOG_TAIL_WARN)) {
 			xfs_alert_tag(log->l_mp, XFS_PTAG_LOGRES,
-				"%s: space > BBTOB(tail_blocks)", __func__);
-			log->l_flags |= XLOG_TAIL_WARN;
+				"%s: space (%d) > BBTOB(tail_blocks) (%d)", __func__, space, BBTOB(tail_blocks));
+			//log->l_flags |= XLOG_TAIL_WARN;
 		}
 	}
 }
-- 
2.20.1


  reply	other threads:[~2019-10-14 18:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14 18:12 [RFC PATCH 0/3] xfs: grant head concurrency experiment Brian Foster
2019-10-14 18:12 ` Brian Foster [this message]
2019-10-14 18:12 ` [RFC PATCH 2/3] xfs: fold grant space update into head check function Brian Foster
2019-10-14 18:13 ` [RFC PATCH 3/3] xfs: recheck free reservation on grant head update contention Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191014181300.15494-2-bfoster@redhat.com \
    --to=bfoster@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox