Re: [PATCH v6 05/12] xfs: dont use XFS_IS_QUOTA_RUNNING() for option check

Christoph Hellwig
2019-10-16T08:29:03Z

On Wed, Oct 16, 2019 at 08:41:08AM +0800, Ian Kent wrote:
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 5876c2b551b5..f8770206b66e 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -349,7 +349,7 @@ xfs_parseargs(
> }
>
> #ifndef CONFIG_XFS_QUOTA
> - if (XFS_IS_QUOTA_RUNNING(mp)) {
> + if (mp->m_qflags != 0) {
> xfs_warn(mp, "quota support not available in this kernel.");
> return -EINVAL;
> }

Please also convert to use !IS_ENABLED while you are at it.