public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Ian Kent <raven@themaw.net>
Cc: linux-xfs <linux-xfs@vger.kernel.org>,
	Brian Foster <bfoster@redhat.com>,
	Eric Sandeen <sandeen@sandeen.net>,
	David Howells <dhowells@redhat.com>,
	Dave Chinner <dchinner@redhat.com>,
	Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH v6 03/12] xfs: remove unused mount info field m_fsname_len
Date: Wed, 16 Oct 2019 11:26:07 -0700	[thread overview]
Message-ID: <20191016182607.GC13108@magnolia> (raw)
In-Reply-To: <157118645790.9678.2717342742220454176.stgit@fedora-28>

On Wed, Oct 16, 2019 at 08:40:58AM +0800, Ian Kent wrote:
> The mount info field m_fsname_len is not used anywhere, remove it.
> 
> Signed-off-by: Ian Kent <raven@themaw.net>

With hch's comments applied,

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  fs/xfs/xfs_mount.h |    1 -
>  fs/xfs/xfs_super.c |    1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
> index fdb60e09a9c5..b3230f7ca2bf 100644
> --- a/fs/xfs/xfs_mount.h
> +++ b/fs/xfs/xfs_mount.h
> @@ -90,7 +90,6 @@ typedef struct xfs_mount {
>  
>  	struct xfs_buf		*m_sb_bp;	/* buffer for superblock */
>  	char			*m_fsname;	/* filesystem name */
> -	int			m_fsname_len;	/* strlen of fs name */
>  	char			*m_rtname;	/* realtime device name */
>  	char			*m_logname;	/* external log device name */
>  	int			m_bsize;	/* fs logical block size */
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 1bb7ede5d75b..cfa306f62bec 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -172,7 +172,6 @@ xfs_parseargs(
>  	mp->m_fsname = kstrndup(sb->s_id, MAXNAMELEN, GFP_KERNEL);
>  	if (!mp->m_fsname)
>  		return -ENOMEM;
> -	mp->m_fsname_len = strlen(mp->m_fsname) + 1;
>  
>  	/*
>  	 * Copy binary VFS mount flags we are interested in.
> 

  parent reply	other threads:[~2019-10-16 18:28 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16  0:40 [PATCH v6 00/12] xfs: mount API patch series Ian Kent
2019-10-16  0:40 ` [PATCH v6 01/12] vfs: add missing blkdev_put() in get_tree_bdev() Ian Kent
2019-10-16  0:40 ` [PATCH v6 02/12] xfs: remove very old mount option Ian Kent
2019-10-16  8:26   ` Christoph Hellwig
2019-10-16 18:25   ` Darrick J. Wong
2019-10-16  0:40 ` [PATCH v6 03/12] xfs: remove unused mount info field m_fsname_len Ian Kent
2019-10-16  8:26   ` Christoph Hellwig
2019-10-16 18:26   ` Darrick J. Wong [this message]
2019-10-16  0:41 ` [PATCH v6 04/12] xfs: use super s_id instead of mount info m_fsname Ian Kent
2019-10-16  8:27   ` Christoph Hellwig
2019-10-16 18:27   ` Darrick J. Wong
2019-10-16  0:41 ` [PATCH v6 05/12] xfs: dont use XFS_IS_QUOTA_RUNNING() for option check Ian Kent
2019-10-16  8:28   ` Christoph Hellwig
2019-10-16 18:28   ` Darrick J. Wong
2019-10-16  0:41 ` [PATCH v6 06/12] xfs: add xfs_remount_rw() helper Ian Kent
2019-10-16  8:30   ` Christoph Hellwig
2019-10-16 18:29   ` Darrick J. Wong
2019-10-16  0:41 ` [PATCH v6 07/12] xfs: add xfs_remount_ro() helper Ian Kent
2019-10-16  8:31   ` Christoph Hellwig
2019-10-16 18:29   ` Darrick J. Wong
2019-10-16  0:41 ` [PATCH v6 08/12] xfs: refactor suffix_kstrtoint() Ian Kent
2019-10-16  8:34   ` Christoph Hellwig
2019-10-16 15:37     ` Darrick J. Wong
2019-10-16  0:41 ` [PATCH v6 09/12] xfs: refactor xfs_parseags() Ian Kent
2019-10-16  8:36   ` Christoph Hellwig
2019-10-16  0:41 ` [PATCH v6 10/12] xfs: move xfs_parseargs() validation to a helper Ian Kent
2019-10-16  8:40   ` Christoph Hellwig
2019-10-17  0:58     ` Ian Kent
2019-10-17  6:48       ` Christoph Hellwig
2019-10-23  2:59     ` Ian Kent
2019-10-16  0:41 ` [PATCH v6 11/12] xfs: dont set sb in xfs_mount_alloc() Ian Kent
2019-10-16  8:36   ` Christoph Hellwig
2019-10-16  0:41 ` [PATCH v6 12/12] xfs: switch to use the new mount-api Ian Kent
2019-10-16 18:18   ` Christoph Hellwig
2019-10-17  1:13     ` Ian Kent
2019-10-17  4:53       ` Darrick J. Wong
2019-10-17  6:51         ` Christoph Hellwig
2019-10-18  0:38           ` Ian Kent
2019-10-23  3:17     ` Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191016182607.GC13108@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=bfoster@redhat.com \
    --cc=dchinner@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=raven@themaw.net \
    --cc=sandeen@sandeen.net \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox