Re: [PATCH v6 12/12] xfs: switch to use the new mount-api

Ian Kent
2019-10-23T03:17:15Z

On Wed, 2019-10-16 at 11:18 -0700, Christoph Hellwig wrote:
>
> Btw, can we keep all the mount code together where most of it already
> is at the top of the file? I know the existing version has some
> remount
> stuff at the bottom, but as that get entirely rewritten we might as
> well
> move it all up.

I like the recommendation to bring all the mounting code together.

I think that would mean also moving xfs_fs_fill_super() and that
would mean adding several forward declarations because the several
functions called by xfs_fs_fill_super() appear to have reasonably
sensible ordering already.

Personally I think adding the forward declarations is worthwhile
to get improved code order.

So I'll do that but thought I should mention it in case anyone
has a different POV.

Ian