Re: [PATCH v6 07/12] xfs: add xfs_remount_ro() helper

Christoph Hellwig
2019-10-16T08:31:42Z

> + /*
> + * Cancel background eofb scanning so it cannot race with the
> + * final log force+buftarg wait and deadlock the remount.
> + */

> + /*
> + * Before we sync the metadata, we need to free up the reserve
> + * block pool so that the used block count in the superblock on
> + * disk is correct at the end of the remount. Stash the current
> + * reserve pool size so that if we get remounted rw, we can
> + * return it to the same size.
> + */

Please use up the full 80 chars available for each line for comments.

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>