Re: [PATCH v6 10/12] xfs: move xfs_parseargs() validation to a helper

Christoph Hellwig
2019-10-17T06:48:28Z

On Thu, Oct 17, 2019 at 08:58:26AM +0800, Ian Kent wrote:
> > > + if (nooptions)
> > > + goto noopts;
> >
> > This option is always false in this patch. I'd suggest you only add
> > it once we actually add a user.
>
> Thanks for looking at the series and for the comments.
> I'll get on with the recommended changes and post an update.

And for this one I'm not sure the goto option actually ever makes sense,
even with the final patch applied. To me it looks like splitting the
function into two might be much cleaner.