Re: [PATCH v6 03/12] xfs: remove unused mount info field m_fsname_len

Darrick J. Wong
2019-10-16T18:28:28Z

On Wed, Oct 16, 2019 at 08:40:58AM +0800, Ian Kent wrote:
> The mount info field m_fsname_len is not used anywhere, remove it.
>
> Signed-off-by: Ian Kent <raven@themaw.net>

With hch's comments applied,

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> fs/xfs/xfs_mount.h | 1 -
> fs/xfs/xfs_super.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
> index fdb60e09a9c5..b3230f7ca2bf 100644
> --- a/fs/xfs/xfs_mount.h
> +++ b/fs/xfs/xfs_mount.h
> @@ -90,7 +90,6 @@ typedef struct xfs_mount {
>
> struct xfs_buf *m_sb_bp; /* buffer for superblock */
> char *m_fsname; /* filesystem name */
> - int m_fsname_len; /* strlen of fs name */
> char *m_rtname; /* realtime device name */
> char *m_logname; /* external log device name */
> int m_bsize; /* fs logical block size */
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 1bb7ede5d75b..cfa306f62bec 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -172,7 +172,6 @@ xfs_parseargs(
> mp->m_fsname = kstrndup(sb->s_id, MAXNAMELEN, GFP_KERNEL);
> if (!mp->m_fsname)
> return -ENOMEM;
> - mp->m_fsname_len = strlen(mp->m_fsname) + 1;
>
> /*
> * Copy binary VFS mount flags we are interested in.
>