From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: kaixuxia <xiakaixu1987@gmail.com>
Cc: linux-xfs@vger.kernel.org, newtongao@tencent.com, jasperwang@tencent.com
Subject: Re: [PATCH] xfs: remove the duplicated inode log fieldmask set
Date: Mon, 21 Oct 2019 08:47:05 -0700 [thread overview]
Message-ID: <20191021154705.GF6719@magnolia> (raw)
In-Reply-To: <8df3c417-4fb2-f37b-6f27-3df069903c08@gmail.com>
On Mon, Oct 21, 2019 at 05:32:43PM +0800, kaixuxia wrote:
> The xfs_bumplink() call has set the inode log fieldmask XFS_ILOG_CORE,
> so the next xfs_trans_log_inode() call is not necessary.
>
> Signed-off-by: kaixuxia <kaixuxia@tencent.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_inode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
> index 18f4b26..b0c81f1d 100644
> --- a/fs/xfs/xfs_inode.c
> +++ b/fs/xfs/xfs_inode.c
> @@ -3327,7 +3327,6 @@ struct xfs_iunlink {
> goto out_trans_cancel;
>
> xfs_bumplink(tp, wip);
> - xfs_trans_log_inode(tp, wip, XFS_ILOG_CORE);
> VFS_I(wip)->i_state &= ~I_LINKABLE;
> }
>
> --
> 1.8.3.1
>
> --
> kaixuxia
prev parent reply other threads:[~2019-10-21 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 9:32 [PATCH] xfs: remove the duplicated inode log fieldmask set kaixuxia
2019-10-21 15:47 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021154705.GF6719@magnolia \
--to=darrick.wong@oracle.com \
--cc=jasperwang@tencent.com \
--cc=linux-xfs@vger.kernel.org \
--cc=newtongao@tencent.com \
--cc=xiakaixu1987@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox