* [PATCH] xfs: remove the duplicated inode log fieldmask set
@ 2019-10-21 9:32 kaixuxia
2019-10-21 15:47 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: kaixuxia @ 2019-10-21 9:32 UTC (permalink / raw)
To: linux-xfs; +Cc: Darrick J. Wong, newtongao, jasperwang
The xfs_bumplink() call has set the inode log fieldmask XFS_ILOG_CORE,
so the next xfs_trans_log_inode() call is not necessary.
Signed-off-by: kaixuxia <kaixuxia@tencent.com>
---
fs/xfs/xfs_inode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index 18f4b26..b0c81f1d 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -3327,7 +3327,6 @@ struct xfs_iunlink {
goto out_trans_cancel;
xfs_bumplink(tp, wip);
- xfs_trans_log_inode(tp, wip, XFS_ILOG_CORE);
VFS_I(wip)->i_state &= ~I_LINKABLE;
}
--
1.8.3.1
--
kaixuxia
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] xfs: remove the duplicated inode log fieldmask set
2019-10-21 9:32 [PATCH] xfs: remove the duplicated inode log fieldmask set kaixuxia
@ 2019-10-21 15:47 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2019-10-21 15:47 UTC (permalink / raw)
To: kaixuxia; +Cc: linux-xfs, newtongao, jasperwang
On Mon, Oct 21, 2019 at 05:32:43PM +0800, kaixuxia wrote:
> The xfs_bumplink() call has set the inode log fieldmask XFS_ILOG_CORE,
> so the next xfs_trans_log_inode() call is not necessary.
>
> Signed-off-by: kaixuxia <kaixuxia@tencent.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_inode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
> index 18f4b26..b0c81f1d 100644
> --- a/fs/xfs/xfs_inode.c
> +++ b/fs/xfs/xfs_inode.c
> @@ -3327,7 +3327,6 @@ struct xfs_iunlink {
> goto out_trans_cancel;
>
> xfs_bumplink(tp, wip);
> - xfs_trans_log_inode(tp, wip, XFS_ILOG_CORE);
> VFS_I(wip)->i_state &= ~I_LINKABLE;
> }
>
> --
> 1.8.3.1
>
> --
> kaixuxia
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-21 15:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-21 9:32 [PATCH] xfs: remove the duplicated inode log fieldmask set kaixuxia
2019-10-21 15:47 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox