From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Ian Kent <raven@themaw.net>
Cc: linux-xfs <linux-xfs@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Brian Foster <bfoster@redhat.com>,
Eric Sandeen <sandeen@sandeen.net>,
David Howells <dhowells@redhat.com>,
Dave Chinner <dchinner@redhat.com>,
Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH v7 06/17] xfs: use kmem functions for struct xfs_mount
Date: Thu, 24 Oct 2019 08:26:11 -0700 [thread overview]
Message-ID: <20191024152611.GQ913374@magnolia> (raw)
In-Reply-To: <157190346680.27074.12024650426066059590.stgit@fedora-28>
On Thu, Oct 24, 2019 at 03:51:06PM +0800, Ian Kent wrote:
> The remount function uses the kmem functions for allocating and freeing
> struct xfs_mount, for consistency use the kmem functions everwhere for
> struct xfs_mount.
>
> Signed-off-by: Ian Kent <raven@themaw.net>
Looks fine (there are direct callers of kmalloc for anyone who wants to
take on a small cleanup...)
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_super.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index a0805b74256c..896609827e3c 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1535,7 +1535,7 @@ xfs_mount_alloc(
> {
> struct xfs_mount *mp;
>
> - mp = kzalloc(sizeof(struct xfs_mount), GFP_KERNEL);
> + mp = kmem_alloc(sizeof(struct xfs_mount), KM_ZERO);
> if (!mp)
> return NULL;
>
> @@ -1749,7 +1749,7 @@ xfs_fs_fill_super(
> out_free_names:
> sb->s_fs_info = NULL;
> xfs_free_names(mp);
> - kfree(mp);
> + kmem_free(mp);
> out:
> return error;
>
> @@ -1781,7 +1781,7 @@ xfs_fs_put_super(
>
> sb->s_fs_info = NULL;
> xfs_free_names(mp);
> - kfree(mp);
> + kmem_free(mp);
> }
>
> STATIC struct dentry *
>
next prev parent reply other threads:[~2019-10-24 15:26 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 7:50 [PATCH v7 00/17] xfs: mount API patch series Ian Kent
2019-10-24 7:50 ` [PATCH v7 01/17] vfs: add missing blkdev_put() in get_tree_bdev() Ian Kent
2019-10-24 7:50 ` [PATCH v7 02/17] xfs: remove very old mount option Ian Kent
2019-10-24 7:50 ` [PATCH v7 03/17] xfs: remove unused struct xfs_mount field m_fsname_len Ian Kent
2019-10-24 7:50 ` [PATCH v7 04/17] xfs: use super s_id instead of struct xfs_mount m_fsname Ian Kent
2019-10-24 7:51 ` [PATCH v7 05/17] xfs: dont use XFS_IS_QUOTA_RUNNING() for option check Ian Kent
2019-10-25 13:52 ` Christoph Hellwig
2019-10-24 7:51 ` [PATCH v7 06/17] xfs: use kmem functions for struct xfs_mount Ian Kent
2019-10-24 15:26 ` Darrick J. Wong [this message]
2019-10-25 13:53 ` Christoph Hellwig
2019-10-24 7:51 ` [PATCH v7 07/17] xfs: move xfs_mount_alloc to be with parsing code Ian Kent
2019-10-25 14:31 ` Christoph Hellwig
2019-10-24 7:51 ` [PATCH v7 08/17] xfs: merge freeing of mp names and mp Ian Kent
2019-10-24 15:28 ` Darrick J. Wong
2019-10-25 14:37 ` Christoph Hellwig
2019-10-24 7:51 ` [PATCH v7 09/17] xfs: add xfs_remount_rw() helper Ian Kent
2019-10-24 15:31 ` Darrick J. Wong
2019-10-24 21:53 ` Ian Kent
2019-10-24 23:12 ` Darrick J. Wong
2019-10-25 16:45 ` Christoph Hellwig
2019-10-24 7:51 ` [PATCH v7 10/17] xfs: add xfs_remount_ro() helper Ian Kent
2019-10-24 15:32 ` Darrick J. Wong
2019-10-24 7:51 ` [PATCH v7 11/17] xfs: refactor suffix_kstrtoint() Ian Kent
2019-10-24 15:38 ` Darrick J. Wong
2019-10-24 22:02 ` Ian Kent
2019-10-25 14:39 ` Christoph Hellwig
2019-10-24 7:51 ` [PATCH v7 12/17] xfs: avoid redundant checks when options is empty Ian Kent
2019-10-24 15:40 ` Darrick J. Wong
2019-10-25 14:42 ` Christoph Hellwig
2019-10-24 7:51 ` [PATCH v7 13/17] xfs: refactor xfs_parseags() Ian Kent
2019-10-24 15:41 ` Darrick J. Wong
2019-10-24 7:51 ` [PATCH v7 14/17] xfs: move xfs_parseargs() validation to a helper Ian Kent
2019-10-24 15:51 ` Darrick J. Wong
2019-10-24 7:51 ` [PATCH v7 15/17] xfs: dont set sb in xfs_mount_alloc() Ian Kent
2019-10-24 7:51 ` [PATCH v7 16/17] xfs: move xfs_fs_fill_super() to be with parsing code Ian Kent
2019-10-24 7:52 ` [PATCH v7 17/17] xfs: switch to use the new mount-api Ian Kent
2019-10-25 17:01 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024152611.GQ913374@magnolia \
--to=darrick.wong@oracle.com \
--cc=bfoster@redhat.com \
--cc=dchinner@redhat.com \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=raven@themaw.net \
--cc=sandeen@sandeen.net \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox