From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: use xfs_inode_buftarg in xfs_file_dio_aio_write
Date: Thu, 24 Oct 2019 22:29:53 -0700 [thread overview]
Message-ID: <20191025052953.GC913374@magnolia> (raw)
In-Reply-To: <20191025021852.20172-3-hch@lst.de>
On Fri, Oct 25, 2019 at 11:18:51AM +0900, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_file.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index ee4ebb7904f6..156238d5af19 100644
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -487,8 +487,7 @@ xfs_file_dio_aio_write(
> int unaligned_io = 0;
> int iolock;
> size_t count = iov_iter_count(from);
> - struct xfs_buftarg *target = XFS_IS_REALTIME_INODE(ip) ?
> - mp->m_rtdev_targp : mp->m_ddev_targp;
> + struct xfs_buftarg *target = xfs_inode_buftarg(ip);
>
> /* DIO must be aligned to device logical sector size */
> if ((iocb->ki_pos | count) & target->bt_logical_sectormask)
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-10-25 5:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 2:18 cleanup buftarg lookup Christoph Hellwig
2019-10-25 2:18 ` [PATCH 1/3] xfs: add a xfs_inode_buftarg helper Christoph Hellwig
2019-10-25 5:31 ` Darrick J. Wong
2019-10-25 2:18 ` [PATCH 2/3] xfs: use xfs_inode_buftarg in xfs_file_dio_aio_write Christoph Hellwig
2019-10-25 5:29 ` Darrick J. Wong [this message]
2019-10-25 2:18 ` [PATCH 3/3] xfs: use xfs_inode_buftarg in xfs_file_ioctl Christoph Hellwig
2019-10-25 5:29 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025052953.GC913374@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox