From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 004FDCA9EA0 for ; Fri, 25 Oct 2019 09:50:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D195021929 for ; Fri, 25 Oct 2019 09:50:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407211AbfJYJuI (ORCPT ); Fri, 25 Oct 2019 05:50:08 -0400 Received: from verein.lst.de ([213.95.11.211]:50264 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407918AbfJYJuI (ORCPT ); Fri, 25 Oct 2019 05:50:08 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 652C168AFE; Fri, 25 Oct 2019 11:50:05 +0200 (CEST) Date: Fri, 25 Oct 2019 11:50:05 +0200 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/4] fs: add generic UNRESVSP and ZERO_RANGE ioctl handlers Message-ID: <20191025095005.GA9613@lst.de> References: <20191025023609.22295-1-hch@lst.de> <20191025023609.22295-3-hch@lst.de> <20191025054452.GF913374@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191025054452.GF913374@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, Oct 24, 2019 at 10:44:52PM -0700, Darrick J. Wong wrote: > > case XFS_IOC_FREESP: > > - case XFS_IOC_UNRESVSP: > > case XFS_IOC_ALLOCSP64: > > - case XFS_IOC_FREESP64: > > - case XFS_IOC_UNRESVSP64: > > - case XFS_IOC_ZERO_RANGE: { > > + case XFS_IOC_FREESP64: { > > Ok, so this hoists everything to the vfs except for ALLOCSP and FREESP, > which seems to be ... "set new size; allocate between old and new EOF if > appropriate"? > > I'm asking because I was never really clear on what those things are > supposed to do. :) Yes. ALLOCSP/FREESP have so weird semantics that we never added the equivalent functionality to fallocate.