From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/4] fs: add generic UNRESVSP and ZERO_RANGE ioctl handlers
Date: Sun, 27 Oct 2019 07:56:09 +1100 [thread overview]
Message-ID: <20191026205609.GJ4614@dread.disaster.area> (raw)
In-Reply-To: <20191025095005.GA9613@lst.de>
On Fri, Oct 25, 2019 at 11:50:05AM +0200, Christoph Hellwig wrote:
> On Thu, Oct 24, 2019 at 10:44:52PM -0700, Darrick J. Wong wrote:
> > > case XFS_IOC_FREESP:
> > > - case XFS_IOC_UNRESVSP:
> > > case XFS_IOC_ALLOCSP64:
> > > - case XFS_IOC_FREESP64:
> > > - case XFS_IOC_UNRESVSP64:
> > > - case XFS_IOC_ZERO_RANGE: {
> > > + case XFS_IOC_FREESP64: {
> >
> > Ok, so this hoists everything to the vfs except for ALLOCSP and FREESP,
> > which seems to be ... "set new size; allocate between old and new EOF if
> > appropriate"?
> >
> > I'm asking because I was never really clear on what those things are
> > supposed to do. :)
>
> Yes. ALLOCSP/FREESP have so weird semantics that we never added the
> equivalent functionality to fallocate.
We should plan to deprecate and remove ALLOCSP/FREESP - they just
aren't useful APIs anymore, and nobody has used them in preference
to the RESVSP/UNRESVSP ioctls since they were introduced in ~1998
with unwritten extents. We probably should have deprecated then 10
years ago....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2019-10-26 20:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 2:36 clean up xfs space management interfaces Christoph Hellwig
2019-10-25 2:36 ` [PATCH 1/4] xfs: don't implement XFS_IOC_RESVSP / XFS_IOC_RESVSP64 directly Christoph Hellwig
2019-10-25 5:32 ` Darrick J. Wong
2019-10-25 2:36 ` [PATCH 2/4] fs: add generic UNRESVSP and ZERO_RANGE ioctl handlers Christoph Hellwig
2019-10-25 5:44 ` Darrick J. Wong
2019-10-25 9:50 ` Christoph Hellwig
2019-10-26 20:56 ` Dave Chinner [this message]
2019-10-27 15:19 ` Christoph Hellwig
2019-10-25 2:36 ` [PATCH 3/4] xfs: disable xfs_ioc_space for always COW inodes Christoph Hellwig
2019-10-25 5:45 ` Darrick J. Wong
2019-10-25 2:36 ` [PATCH 4/4] xfs: consolidate preallocation in xfs_file_fallocate Christoph Hellwig
2019-10-25 5:48 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191026205609.GJ4614@dread.disaster.area \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox