From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: properly serialise fallocate against AIO+DIO
Date: Wed, 30 Oct 2019 09:29:55 +1100 [thread overview]
Message-ID: <20191029222955.GO4614@dread.disaster.area> (raw)
In-Reply-To: <20191029100342.GA41131@bfoster>
On Tue, Oct 29, 2019 at 06:03:42AM -0400, Brian Foster wrote:
> On Tue, Oct 29, 2019 at 03:41:33PM +1100, Dave Chinner wrote:
>
> FWIW, I find something like the following a bit more clear/concise on
> the whole:
>
> /*
> + * Once AIO and DIO has drained we flush and (if necessary) invalidate
> + * the cached range over the first operation we are about to run. We
> + * include zero and collapse here because they both start with a hole
> + * punch over the target range. Insert and collapse both invalidate the
> + * broader range affected by the shift in xfs_prepare_shift().
> */
Yup, much better. Thanks! :)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2019-10-29 22:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 3:48 [PATCH] xfs: properly serialise fallocate against AIO+DIO Dave Chinner
2019-10-29 4:02 ` Dave Chinner
2019-10-29 4:19 ` Darrick J. Wong
2019-10-29 4:41 ` Dave Chinner
2019-10-29 10:03 ` Brian Foster
2019-10-29 20:22 ` Darrick J. Wong
2019-10-29 22:29 ` Dave Chinner [this message]
2019-10-29 20:22 ` Darrick J. Wong
2019-10-29 20:23 ` [RFC PATCH] generic: test race between appending AIO DIO and fallocate Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029222955.GO4614@dread.disaster.area \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox