From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH V2] xfs: properly serialise fallocate against AIO+DIO
Date: Wed, 30 Oct 2019 07:26:22 -0700 [thread overview]
Message-ID: <20191030142622.GA10453@infradead.org> (raw)
In-Reply-To: <20191029223752.28562-1-david@fromorbit.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
Btw, I've been pondering multiple times if we can kill off i_dio_count
again, at least for iomap users. I've added in the request of Thomas
how want to kill non-owner rw_semaphore unlocks. But it turns out those
were needed in other placeѕ and have been added back at least partially.
I'll try to just use those again when I find some time, which should
simplify a lot of the mess we around waiting for direct I/O.
next prev parent reply other threads:[~2019-10-30 14:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 22:37 [PATCH V2] xfs: properly serialise fallocate against AIO+DIO Dave Chinner
2019-10-29 23:33 ` Darrick J. Wong
2019-10-29 23:54 ` Dave Chinner
2019-10-30 12:46 ` Brian Foster
2019-10-30 14:26 ` Christoph Hellwig [this message]
2019-10-31 21:06 ` Dave Chinner
2019-11-20 2:38 ` Darrick J. Wong
2019-11-21 6:50 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191030142622.GA10453@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox