From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 654A7CA9EC5 for ; Wed, 30 Oct 2019 17:56:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4501B2087F for ; Wed, 30 Oct 2019 17:56:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727161AbfJ3R4P (ORCPT ); Wed, 30 Oct 2019 13:56:15 -0400 Received: from verein.lst.de ([213.95.11.211]:47034 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727012AbfJ3R4P (ORCPT ); Wed, 30 Oct 2019 13:56:15 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 2CE7568C7B; Wed, 30 Oct 2019 18:56:14 +0100 (CET) Date: Wed, 30 Oct 2019 18:56:14 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , linux-xfs@vger.kernel.org Subject: Re: [PATCH 4/8] xfs: don't log the inode in xfs_fs_map_blocks if it wasn't modified Message-ID: <20191030175614.GA19244@lst.de> References: <20191025150336.19411-1-hch@lst.de> <20191025150336.19411-5-hch@lst.de> <20191028161245.GD15222@magnolia> <20191029075843.GD18999@lst.de> <20191030161248.GI15222@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191030161248.GI15222@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Oct 30, 2019 at 09:12:48AM -0700, Darrick J. Wong wrote: > > Actually even for !write we should not see delalloc blocks here. > > So I'll fix up the assert in a separate prep patch. > > I could just fix it, unless you're about to resend the whole series? I have the series ready to resend.