From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: constify the buffer pointer arguments to error functions
Date: Mon, 4 Nov 2019 11:25:48 -0800 [thread overview]
Message-ID: <20191104192548.GB25903@infradead.org> (raw)
In-Reply-To: <157281983593.4150947.13692433066759624464.stgit@magnolia>
On Sun, Nov 03, 2019 at 02:23:55PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Some of the xfs error message functions take a pointer to a buffer that
> will be dumped to the system log. The logging functions don't change
> the contents, so constify all the parameters. This enables the next
> patch to ensure that we log bad metadata when we encounter it.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2019-11-04 19:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-03 22:23 [PATCH 0/3] xfs: tidy up corruption reporting Darrick J. Wong
2019-11-03 22:23 ` [PATCH 1/3] xfs: relax shortform directory size checks Darrick J. Wong
2019-11-04 15:22 ` Carlos Maiolino
2019-11-04 19:23 ` Christoph Hellwig
2019-11-03 22:23 ` [PATCH 2/3] xfs: constify the buffer pointer arguments to error functions Darrick J. Wong
2019-11-04 15:44 ` Carlos Maiolino
2019-11-04 19:25 ` Christoph Hellwig [this message]
2019-11-03 22:24 ` [PATCH 3/3] xfs: always log corruption errors Darrick J. Wong
2019-11-04 15:44 ` Carlos Maiolino
2019-11-04 19:26 ` Christoph Hellwig
2019-11-04 15:22 ` [PATCH 0/3] xfs: tidy up corruption reporting Christoph Hellwig
2019-11-04 16:34 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104192548.GB25903@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).