Re: [PATCH 4/6] xfs: add a XFS_CORRUPT_ON macro

Darrick J. Wong
2019-11-05T00:51:38Z

On Mon, Nov 04, 2019 at 04:48:28PM -0800, Christoph Hellwig wrote:
> On Sun, Nov 03, 2019 at 02:24:30PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Add a new macro, XFS_CORRUPT_ON, which we will use to integrate some
> > corruption reporting when the corruption test expression is true. This
> > will be used in the next patch to remove the ugly XFS_WANT_CORRUPT*
> > macros.
>
> I don't particularly like the XFS_CORRUPT_ON name, and seeing how it
> is used I like it even less.
>
> Maybe XFS_IS_CORRUPT instead?

Fine with me.

I'd derived the name from WARN_ON, then realized that if you squint just
right it becomes "XFS_CORRUPTION" and then wondered if I should just
shorten it to "IS_BAD()" but sent it out anyway. :)

--D