Re: [PATCH 1/6] xfs: decrease indenting problems in xfs_dabuf_map

Christoph Hellwig
2019-11-05T00:44:19Z

On Sun, Nov 03, 2019 at 02:24:10PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Refactor the code that complains when a dir/attr mapping doesn't exist
> but the caller requires a mapping. This small restructuring helps us to
> reduce the indenting level.

I have to say I hate the calling convention here.. But the actual
change is perfectly fine, so:

Reviewed-by: Christoph Hellwig <hch@lst.de>