From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 2/2] xfs: periodically yield scrub threads to the scheduler
Date: Wed, 6 Nov 2019 15:44:46 +0100 [thread overview]
Message-ID: <20191106144446.GB17196@lst.de> (raw)
In-Reply-To: <157301538629.678524.5328247190031479757.stgit@magnolia>
On Tue, Nov 05, 2019 at 08:43:06PM -0800, Darrick J. Wong wrote:
> +++ b/fs/xfs/scrub/common.h
> @@ -14,8 +14,20 @@
> static inline bool
> xchk_should_terminate(
> struct xfs_scrub *sc,
> - int *error)
> + int *error)
> {
> +#if !IS_ENABLED(CONFIG_PREEMPT)
> + /*
> + * If preemption is disabled, we need to yield to the scheduler every
> + * few seconds so that we don't run afoul of the soft lockup watchdog
> + * or RCU stall detector.
> + */
> + if (sc->next_yield != 0 && time_after(jiffies, sc->next_yield))
> + return false;
> + schedule();
> + sc->next_yield = jiffies + msecs_to_jiffies(5000);
> +#endif
This looks weird. Can't we just do a cond_resched() here?
next prev parent reply other threads:[~2019-11-06 14:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 4:42 [PATCH 0/2] xfs: fix scrub timeout warnings Darrick J. Wong
2019-11-06 4:43 ` [PATCH 1/2] xfs: add missing early termination checks to record scrubbing functions Darrick J. Wong
2019-11-06 14:43 ` Christoph Hellwig
2019-11-06 4:43 ` [PATCH 2/2] xfs: periodically yield scrub threads to the scheduler Darrick J. Wong
2019-11-06 14:44 ` Christoph Hellwig [this message]
2019-11-06 16:13 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106144446.GB17196@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox