From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Christoph Hellwig <hch@infradead.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: periodically yield scrub threads to the scheduler
Date: Wed, 6 Nov 2019 08:13:12 -0800 [thread overview]
Message-ID: <20191106161312.GL4153244@magnolia> (raw)
In-Reply-To: <20191106144446.GB17196@lst.de>
On Wed, Nov 06, 2019 at 03:44:46PM +0100, Christoph Hellwig wrote:
> On Tue, Nov 05, 2019 at 08:43:06PM -0800, Darrick J. Wong wrote:
> > +++ b/fs/xfs/scrub/common.h
> > @@ -14,8 +14,20 @@
> > static inline bool
> > xchk_should_terminate(
> > struct xfs_scrub *sc,
> > - int *error)
> > + int *error)
> > {
> > +#if !IS_ENABLED(CONFIG_PREEMPT)
> > + /*
> > + * If preemption is disabled, we need to yield to the scheduler every
> > + * few seconds so that we don't run afoul of the soft lockup watchdog
> > + * or RCU stall detector.
> > + */
> > + if (sc->next_yield != 0 && time_after(jiffies, sc->next_yield))
> > + return false;
> > + schedule();
> > + sc->next_yield = jiffies + msecs_to_jiffies(5000);
> > +#endif
>
> This looks weird. Can't we just do a cond_resched() here?
DOH. Yes, probably. Dave even suggested it a few nights ago to fix a
similar problem and apparently I forgot. Will fix. :(
--D
prev parent reply other threads:[~2019-11-06 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 4:42 [PATCH 0/2] xfs: fix scrub timeout warnings Darrick J. Wong
2019-11-06 4:43 ` [PATCH 1/2] xfs: add missing early termination checks to record scrubbing functions Darrick J. Wong
2019-11-06 14:43 ` Christoph Hellwig
2019-11-06 4:43 ` [PATCH 2/2] xfs: periodically yield scrub threads to the scheduler Darrick J. Wong
2019-11-06 14:44 ` Christoph Hellwig
2019-11-06 16:13 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106161312.GL4153244@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox