From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Amir Goldstein <amir73il@gmail.com>,
linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs_io/lsattr: expose FS_XFLAG_HASATTR flag
Date: Wed, 6 Nov 2019 11:07:42 -0800 [thread overview]
Message-ID: <20191106190742.GN4153244@magnolia> (raw)
In-Reply-To: <21d97237-03ef-7388-dbca-ab76ba304205@sandeen.net>
On Wed, Nov 06, 2019 at 12:53:46PM -0600, Eric Sandeen wrote:
>
>
> On 11/6/19 12:52 PM, Darrick J. Wong wrote:
> > On Wed, Nov 06, 2019 at 12:45:55PM -0600, Eric Sandeen wrote:
> >> On 11/6/19 12:29 PM, Amir Goldstein wrote:
>
> >>>>> #define CHATTR_XFLAG_LIST "r"/*p*/"iasAdtPneEfSxC"
> >>>>
> >>>> /me wonders if this should have /*X*/ commented out the same way we do
> >>>> for "p".
> >>>
> >>> Sure. Eric, please let me know if you want a re-submit for this.
> >>
> >> Ummm I'll just stage it now and add it so I don't forget
> >>
> >> like:
> >>
> >> #define CHATTR_XFLAG_LIST "r"/*p*/"iasAdtPneEfS"/*X*/"xC"
> >>
> >> that, right?
> >
> > Right.
>
>
> Actually for consistent ordering w/ the array, I guess maybe
>
> #define CHATTR_XFLAG_LIST "r"/*p*/"iasAdtPneEfSxC"/*X*/
Sure. /me is done beating this hoss.
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> Thanks
>
> -Eric
next prev parent reply other threads:[~2019-11-06 19:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 5:58 [PATCH] xfs_io/lsattr: expose FS_XFLAG_HASATTR flag Amir Goldstein
2019-11-06 16:01 ` Darrick J. Wong
2019-11-06 18:29 ` Amir Goldstein
2019-11-06 18:45 ` Eric Sandeen
2019-11-06 18:52 ` Darrick J. Wong
2019-11-06 18:53 ` Eric Sandeen
2019-11-06 19:07 ` Darrick J. Wong [this message]
2019-11-08 6:50 ` Darrick J. Wong
2019-11-08 13:39 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106190742.GN4153244@magnolia \
--to=darrick.wong@oracle.com \
--cc=amir73il@gmail.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox