Re: [PATCH 02/46] xfs: use unsigned int for all size values in struct xfs_da_geometry

Darrick J. Wong
2019-11-07T22:34:02Z

On Thu, Nov 07, 2019 at 07:23:26PM +0100, Christoph Hellwig wrote:
> None of these can ever be negative, so use unsigned types.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks ok to me,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> fs/xfs/libxfs/xfs_da_btree.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_da_btree.h b/fs/xfs/libxfs/xfs_da_btree.h
> index 02f7a21ab3a5..01b0bbe8b266 100644
> --- a/fs/xfs/libxfs/xfs_da_btree.h
> +++ b/fs/xfs/libxfs/xfs_da_btree.h
> @@ -18,12 +18,12 @@ struct xfs_dir_ops;
> * structures will be attached to the xfs_mount.
> */
> struct xfs_da_geometry {
> - int blksize; /* da block size in bytes */
> - int fsbcount; /* da block size in filesystem blocks */
> + unsigned int blksize; /* da block size in bytes */
> + unsigned int fsbcount; /* da block size in filesystem blocks */
> uint8_t fsblog; /* log2 of _filesystem_ block size */
> uint8_t blklog; /* log2 of da block size */
> - uint node_ents; /* # of entries in a danode */
> - int magicpct; /* 37% of block size in bytes */
> + unsigned int node_ents; /* # of entries in a danode */
> + unsigned int magicpct; /* 37% of block size in bytes */
> xfs_dablk_t datablk; /* blockno of dir data v2 */
> xfs_dablk_t leafblk; /* blockno of leaf data v2 */
> xfs_dablk_t freeblk; /* blockno of free data v2 */
> --
> 2.20.1
>