Re: [PATCH] iomap: iomap_bmap should check iomap_apply return value

Christoph Hellwig
2019-11-08T05:51:54Z

On Thu, Nov 07, 2019 at 07:36:17AM -0800, Darrick J. Wong wrote:
> On Thu, Nov 07, 2019 at 09:30:50AM +0100, Christoph Hellwig wrote:
> > On Wed, Nov 06, 2019 at 06:59:27PM -0800, Darrick J. Wong wrote:
> > > From: Darrick J. Wong <darrick.wong@oracle.com>
> > >
> > > Check the return value of iomap_apply and return 0 (i.e. error) if it
> > > didn't succeed.
> >
> > And how could we set the bno value if we didn't succeed?
>
> The iomap_bmap caller supplies an ->iomap_end that returns an error.
>
> Granted there's only one caller and it doesn't, so we could dump this
> patch and just tell Coverity to shut up, but it's odd that this is the
> one place where we ignore the return value.
>
> OTOH it's bmap which has been broken for ages; the more insane behavior
> seen in the wild, the better to scare away users. :P

Oh well. I guess the patch is fine, it just isn't really needed as-is.

Reviewed-by: Christoph Hellwig <hch@lst.de>