From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46D15C5DF60 for ; Fri, 8 Nov 2019 07:20:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 11DBA2178F for ; Fri, 8 Nov 2019 07:20:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="KzIS6FAp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727421AbfKHHUN (ORCPT ); Fri, 8 Nov 2019 02:20:13 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:44168 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725802AbfKHHUN (ORCPT ); Fri, 8 Nov 2019 02:20:13 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA87JPo6083606; Fri, 8 Nov 2019 07:20:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=0HFbGwtq1+MNAUA0ZZW7HPhWQWDEm705CqZVugF/kmk=; b=KzIS6FApoYsjz3dhtzCvIV6iROnmvN9Rk22rQBiefzyO+JrVUGvWQQeoYmK/daMmaN44 MFYqD41YXBAHU+NYoMuLWXIaVCnQ7BYZrup2UOUUcpk1FAdq8EdA/6kS6+2hWKi0aanQ c3lvmHBu8RUavDRFCpC2KmAEFAaO20FLR3ptLXQdgvF9b3i+UjyMdObnQMzKy6ACAYwQ ISB0QKUNL11t8HEDD4ebLbyaUD10unDQIFBblDWQekwDpu9xbWLWzc4uA3N4hWr9wxLz pDyhqBCdl9H2j5QhI7ih4uj4O/vl6TTl5OGq0YzEUGZ10w0gR0MoMcEBBwXloWfK47tq ng== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2w41w1bfn4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 08 Nov 2019 07:20:07 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA87J7ZV023005; Fri, 8 Nov 2019 07:20:07 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 2w41wh1bqb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 08 Nov 2019 07:20:06 +0000 Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id xA87K4On022707; Fri, 8 Nov 2019 07:20:05 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 07 Nov 2019 23:20:04 -0800 Date: Thu, 7 Nov 2019 23:20:02 -0800 From: "Darrick J. Wong" To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 2/3] xfs: clean up weird while loop in xfs_alloc_ag_vextent_near Message-ID: <20191108072002.GO6219@magnolia> References: <157319668531.834585.6920821852974178.stgit@magnolia> <157319669798.834585.10287243947050889974.stgit@magnolia> <20191108071151.GA31526@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191108071151.GA31526@infradead.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9434 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911080072 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9434 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911080072 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, Nov 07, 2019 at 11:11:51PM -0800, Christoph Hellwig wrote: > What tree is this supposed to apply to? It fails against Sorry, I've been reworking these patches against a branch that I hadn't yet pushed to xfs-linux.git (and won't until I can take one more look tomorrow with a fresh brain). In the meantime, you can see my development branch on my personal git repo: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/log/?h=xfs-5.5-dev > xfs/for-next here. Otherwise this looks fine to me. Fine enough for an RVB provided the above? :D --D