From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: remove XFS_IOC_FSSETDM and XFS_IOC_FSSETDM_BY_HANDLE
Date: Thu, 7 Nov 2019 23:49:07 -0800 [thread overview]
Message-ID: <20191108074907.GS6219@magnolia> (raw)
In-Reply-To: <20191108065032.GA30861@lst.de>
On Fri, Nov 08, 2019 at 07:50:32AM +0100, Christoph Hellwig wrote:
> On Thu, Nov 07, 2019 at 10:48:01PM -0800, Darrick J. Wong wrote:
> > On Fri, Nov 08, 2019 at 06:23:03AM +0100, Christoph Hellwig wrote:
> > > Thes ioctls set DMAPI specific flags in the on-disk inode, but there is
> > > no way to actually ever query those flags. The only known user is
> > > xfsrestore with the -D option, which is documented to be only useful
> > > inside a DMAPI enviroment, which isn't supported by upstream XFS.
> >
> > Hmm, shouldn't we deprecate this at least for one or two releases?
> >
> > Even if it's functionally pointless...
>
> It sets a value we can't even retreive. Not sure what the deprecation
> would help with.
Dotting i's and crossing t's. IOWs, not getting ourselves yelled at for
killing something without any warning / bureaucracy. :/
--D
next prev parent reply other threads:[~2019-11-08 7:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 5:23 [PATCH] xfs: remove XFS_IOC_FSSETDM and XFS_IOC_FSSETDM_BY_HANDLE Christoph Hellwig
2019-11-08 6:48 ` Darrick J. Wong
2019-11-08 6:50 ` Christoph Hellwig
2019-11-08 7:49 ` Darrick J. Wong [this message]
2019-11-13 5:09 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108074907.GS6219@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox