From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: remove the unused m_chsize field
Date: Wed, 13 Nov 2019 10:09:19 +1100 [thread overview]
Message-ID: <20191112230919.GR4614@dread.disaster.area> (raw)
In-Reply-To: <20191112013810.GV6219@magnolia>
On Mon, Nov 11, 2019 at 05:38:10PM -0800, Darrick J. Wong wrote:
> On Mon, Nov 11, 2019 at 07:09:57PM +0100, Christoph Hellwig wrote:
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Heh, what was that even used for?
> > - uint m_chsize; /* size of next field */
Inode cluster hash size.
We used to keep a linked list of all the inodes in a cluster in a
separate structure, so that we could easily iterate them when needed
(writeback/cluster freeing). They were kept in a separate hash table
so that they could be used as a quick reference inode cluster buffer
cache as well (IIRC it was to speed up things like xfs_imap_to_bp())
without having the overhead of a full buffer cache lookup...
The need for all this went away with the radix tree indexing and
gang lookups - I guess I missed removing this last fragment.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2019-11-12 23:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 18:09 [PATCH] xfs: remove the unused m_chsize field Christoph Hellwig
2019-11-12 1:38 ` Darrick J. Wong
2019-11-12 21:26 ` Eric Sandeen
2019-11-12 23:09 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112230919.GR4614@dread.disaster.area \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox