From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Dave Chinner <david@fromorbit.com>,
linux-xfs <linux-xfs@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Deepa Dinamani <deepa.kernel@gmail.com>
Subject: Re: [RFC][PATCH] xfs: extended timestamp range
Date: Tue, 12 Nov 2019 21:20:32 -0800 [thread overview]
Message-ID: <20191113052032.GU6219@magnolia> (raw)
In-Reply-To: <CAOQ4uxh0T-cddZ9gwPcY6O=Eg=2g855jYbjic=VwihYPz2ZeBw@mail.gmail.com>
On Wed, Nov 13, 2019 at 07:17:06AM +0200, Amir Goldstein wrote:
> >
> > Practically speaking I'd almost rather drop the precision in order to
> > extend the seconds range, since timestamp updates are only precise to
> > HZ anyway.
> >
>
> FWIW, NTFS and CIFS standard is unsigned 64bit of 100 nanoseconds
> counting from Jan 1, 1601.
>
> >
> > Heh, ok. I'll add an inode flag and kernel auto-upgrade of timestamps
> > to the feature list. It's not like we're trying to add an rmap btree to
> > the filesystem. :)
> >
>
> Exactly.
>
> > >
> > > All right, so how do we proceed?
> > > Arnd, do you want to re-work your series according to this scheme?
> >
> > Lemme read them over again. :)
> >
> > > Is there any core xfs developer that was going to tackle this?
> > >
> > > I'm here, so if you need my help moving things forward let me know.
> >
> > I wrote a trivial garbage version this afternoon, will have something
> > more polished tomorrow. None of this is 5.6 material, we have time.
> >
>
> I wonder if your version has struct xfs_dinode_v3 or it could avoid it.
> There is a benefit in terms of code complexity and test coverage
> to keep the only difference between inode versions in the on-disk
> parsers, while reading into the same struct, the same way as
> old inode versions are read into struct xfs_dinode.
>
> Oh well, I can wait for tomorrow to see the polished version :-)
Well now we noticed that Arnd also changed the disk quota structure
format too, so that'll slow things down as we try to figure out how to
reconcile 34-bit inode seconds vs. 40-bit quota timer seconds.
(Or whatever happens with that)
--D
> Thanks,
> Amir.
next prev parent reply other threads:[~2019-11-13 5:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 21:36 [RFC][PATCH] xfs: extended timestamp range Amir Goldstein
2019-11-11 22:35 ` Darrick J. Wong
2019-11-12 4:00 ` Amir Goldstein
2019-11-12 21:11 ` Dave Chinner
2019-11-13 3:56 ` Darrick J. Wong
2019-11-13 4:08 ` Dave Chinner
2019-11-13 4:42 ` Amir Goldstein
2019-11-13 4:58 ` Darrick J. Wong
2019-11-13 5:17 ` Amir Goldstein
2019-11-13 5:20 ` Darrick J. Wong [this message]
2019-11-18 4:52 ` Amir Goldstein
2019-11-18 8:22 ` Dave Chinner
2019-11-18 9:30 ` Amir Goldstein
2019-11-19 5:34 ` Darrick J. Wong
2019-11-19 13:37 ` Arnd Bergmann
2019-11-13 13:20 ` Arnd Bergmann
2019-11-13 20:40 ` Dave Chinner
2019-11-12 8:25 ` Christoph Hellwig
2019-11-12 16:09 ` Darrick J. Wong
2019-11-12 16:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113052032.GU6219@magnolia \
--to=darrick.wong@oracle.com \
--cc=amir73il@gmail.com \
--cc=arnd@arndb.de \
--cc=david@fromorbit.com \
--cc=deepa.kernel@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox