From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: devirtualize ->m_dirnameops
Date: Wed, 13 Nov 2019 07:59:18 +0100 [thread overview]
Message-ID: <20191113065918.GA2606@lst.de> (raw)
In-Reply-To: <20191113042247.GH6219@magnolia>
On Tue, Nov 12, 2019 at 08:22:47PM -0800, Darrick J. Wong wrote:
> > @@ -718,7 +718,7 @@ xfs_dir2_block_lookup_int(
> > * and buffer. If it's the first case-insensitive match, store
> > * the index and buffer and continue looking for an exact match.
> > */
> > - cmp = mp->m_dirnameops->compname(args, dep->name, dep->namelen);
> > + cmp = xfs_dir2_compname(args, dep->name, dep->namelen);
>
> gcc complains about the unused @mp variable here. With that fixed the
> rest looks ok, so:
What gcc version do you use? I see a consistent pattern lately that
yours (correctly) find initialized but unused variable, but neither my
local one nor the build bot does..
next prev parent reply other threads:[~2019-11-13 6:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 18:04 [PATCH] xfs: devirtualize ->m_dirnameops Christoph Hellwig
2019-11-11 18:10 ` Christoph Hellwig
2019-11-13 4:22 ` Darrick J. Wong
2019-11-13 6:59 ` Christoph Hellwig [this message]
2019-11-13 16:27 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113065918.GA2606@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox