Re: [PATCH 2/9] xfs: improve the xfs_dabuf_map calling conventions

Darrick J. Wong
2019-11-19T17:12:14Z

On Mon, Nov 18, 2019 at 07:25:05AM +0100, Christoph Hellwig wrote:
> On Sun, Nov 17, 2019 at 10:35:21AM -0800, Darrick J. Wong wrote:
> > On Sat, Nov 16, 2019 at 07:22:07PM +0100, Christoph Hellwig wrote:
> > > Use a flags argument with the XFS_DABUF_MAP_HOLE_OK flag to signal that
> > > a hole is okay and not corruption, and return -ENOENT instead of the
> > > nameless -1 to signal that case in the return value.
> >
> > Why not set *nirecs = 0 and return 0 like we sometimes do for bmap
> > lookups?
>
> Sure, I can change it to that for the next version.

Also, I forgot to mention that some of the comments (particularly
xfs_dabuf_map) need to be updated to reflect the new "no mapping" return
style since there's no more @mappedbno, etc.

--D