From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org,
Allison Collins <allison.henderson@oracle.com>
Subject: Re: [PATCH 03/10] xfs: improve the xfs_dabuf_map calling conventions
Date: Wed, 20 Nov 2019 19:20:35 +0100 [thread overview]
Message-ID: <20191120182035.GA11912@lst.de> (raw)
In-Reply-To: <20191120181708.GM6219@magnolia>
On Wed, Nov 20, 2019 at 10:17:08AM -0800, Darrick J. Wong wrote:
> > - error = xfs_dabuf_map(dp, bno, mappedbno, whichfork,
> > - &mapp, &nmap);
> > + error = xfs_dabuf_map(dp, bno,
> > + mappedbno == -1 ? XFS_DABUF_MAP_HOLE_OK : 0,
> > + whichfork, &mapp, &nmap);
> > if (error) {
> > /* mapping a hole is not an error, but we don't continue */
> > - if (error == -1)
> > + if (error == -ENOENT)
>
> Shouldn't this turn into:
>
> if (error || !nmap)
> goto out_free;
>
> Otherwise looks ok to me.
Yes, it should. Looks like that hunk got lost in the reshuffle.
next prev parent reply other threads:[~2019-11-20 18:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 11:17 clean up the dabuf mappedbno interface v2 Christoph Hellwig
2019-11-20 11:17 ` [PATCH 01/10] xfs: simplify mappedbno handling in xfs_da_{get,read}_buf Christoph Hellwig
2019-11-20 11:17 ` [PATCH 02/10] xfs: refactor xfs_dabuf_map Christoph Hellwig
2019-11-20 18:24 ` Darrick J. Wong
2019-11-20 11:17 ` [PATCH 03/10] xfs: improve the xfs_dabuf_map calling conventions Christoph Hellwig
2019-11-20 18:17 ` Darrick J. Wong
2019-11-20 18:20 ` Christoph Hellwig [this message]
2019-11-21 5:44 ` Darrick J. Wong
2019-11-21 6:06 ` Christoph Hellwig
2019-11-21 7:15 ` Darrick J. Wong
2019-11-21 7:20 ` Christoph Hellwig
2019-11-20 19:02 ` Darrick J. Wong
2019-11-20 11:17 ` [PATCH 04/10] xfs: remove the mappedbno argument to xfs_da_reada_buf Christoph Hellwig
2019-11-20 11:17 ` [PATCH 05/10] xfs: remove the mappedbno argument to xfs_attr3_leaf_read Christoph Hellwig
2019-11-20 11:17 ` [PATCH 06/10] xfs: remove the mappedbno argument to xfs_dir3_leaf_read Christoph Hellwig
2019-11-20 11:17 ` [PATCH 07/10] xfs: remove the mappedbno argument to xfs_dir3_leafn_read Christoph Hellwig
2019-11-20 11:17 ` [PATCH 08/10] xfs: split xfs_da3_node_read Christoph Hellwig
2019-11-20 11:17 ` [PATCH 09/10] xfs: remove the mappedbno argument to xfs_da_read_buf Christoph Hellwig
2019-11-20 11:17 ` [PATCH 10/10] xfs: remove the mappedbno argument to xfs_da_get_buf Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191120182035.GA11912@lst.de \
--to=hch@lst.de \
--cc=allison.henderson@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox