Re: [PATCH 1/2] mkfs: Break block discard into chunks of 2 GB

Dave Chinner
2019-11-22T21:00:45Z

On Fri, Nov 22, 2019 at 04:59:21PM +0100, Pavel Reichl wrote:
> On Fri, Nov 22, 2019 at 4:38 PM Darrick J. Wong <darrick.wong@oracle.com> wrote:
> > Also:
> > What is the end goal that you have in mind? Is the progress reporting
> > the ultimate goal? Or is it to break up the BLKDISCARD calls so that
> > someone can ^C a mkfs operation and not have it just sit there
> > continuing to run?
>
> The goal is mainly the progress reporting but the possibility to do ^C
> is also convenient. It seems that some users are not happy about the
> BLKDISCARD taking too long and at the same time not being informed
> about that - so they think that the command actually hung.

Ok, that's a good summary to put in the commit description - it
tells the reviewer exactly what you are trying to acheive, and gives
them context to evaluate it against.

Cheers,

Dave.

--
Dave Chinner
david@fromorbit.com