From: Christoph Hellwig <hch@infradead.org>
To: "Arkadiusz Miśkiewicz" <a.miskiewicz@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-xfs@vger.kernel.org
Subject: Re: WARNING: CPU: 5 PID: 25802 at fs/xfs/libxfs/xfs_bmap.c:4530 xfs_bmapi_convert_delalloc+0x434/0x4a0 [xfs]
Date: Wed, 27 Nov 2019 07:43:53 -0800 [thread overview]
Message-ID: <20191127154353.GA9847@infradead.org> (raw)
In-Reply-To: <c52e2515-272f-476e-7cfa-a2ef23c66b56@gmail.com>
On Fri, Nov 08, 2019 at 08:36:31AM +0100, Arkadiusz Miśkiewicz wrote:
> > The WARN_ON means that conversion of delalloc blocks failed to find
> > free space. Something that should not be possible due to the delalloc
> > reservations. What as the last kernel where you did not see something
> > like this?
> >
>
> 4.20.13 looks ok
> 5.1.15 bad (that warn_on triggered)
>
> on both machines according to my old logs
Sorry for dropping the ball. We have some pretty significant changes
between those version as 5.3 has a pretty big rewrite of the high level
writeback code, and this happens in code called from that. But it
doesn't actually change (or should change) how we use the reservations,
which leaves me a little puzzled. If I gave you an instrumented kernel
with new trace points, could you provide traces based on that?
next prev parent reply other threads:[~2019-11-27 15:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 6:01 WARNING: CPU: 5 PID: 25802 at fs/xfs/libxfs/xfs_bmap.c:4530 xfs_bmapi_convert_delalloc+0x434/0x4a0 [xfs] Arkadiusz Miśkiewicz
2019-11-08 6:56 ` Christoph Hellwig
2019-11-08 7:36 ` Arkadiusz Miśkiewicz
2019-11-27 15:43 ` Christoph Hellwig [this message]
2019-11-27 16:25 ` Arkadiusz Miśkiewicz
2019-11-27 16:26 ` Christoph Hellwig
2021-03-03 15:47 ` Arkadiusz Miśkiewicz
2021-03-04 12:40 ` Brian Foster
2021-03-04 13:52 ` Arkadiusz Miśkiewicz
2021-03-04 15:51 ` Brian Foster
2022-02-21 15:29 ` Arkadiusz Miśkiewicz
2022-03-01 15:09 ` Brian Foster
2022-03-01 22:55 ` Arkadiusz Miśkiewicz
2022-03-02 11:53 ` Brian Foster
2019-11-09 22:38 ` Dave Chinner
2019-11-12 21:22 ` Arkadiusz Miśkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127154353.GA9847@infradead.org \
--to=hch@infradead.org \
--cc=a.miskiewicz@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).