From: Dave Chinner <david@fromorbit.com>
To: Alex Lyakas <alex@zadara.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Eric Sandeen <sandeen@sandeen.net>,
Brian Foster <bfoster@redhat.com>,
linux-xfs@vger.kernel.org
Subject: Re: [RFC-PATCH] xfs: do not update sunit/swidth in the superblock to match those provided during mount
Date: Mon, 2 Dec 2019 10:29:04 +1100 [thread overview]
Message-ID: <20191201232904.GC2695@dread.disaster.area> (raw)
In-Reply-To: <CAOcd+r21Ur=jxvJgUdXs+dQj37EnC=ZWP8F45sLesQFJ_GCejg@mail.gmail.com>
On Sun, Dec 01, 2019 at 11:00:32AM +0200, Alex Lyakas wrote:
> We can definitely adhere to the recommended behavior of setting
> sunit/swidth=1 during mkfs, provided the repair still works after
> mounting with different sunit/swidth.
FWIW, sunit/sw=1fsb doesn't work reliably either, if you grow the
sunit by a large enough value that it changes the alignment of the
root inode....
Essentially, there is no magic bullet here. We need to ensure that
the kernel doesn't do something that breaks assumptions about root
inode location, and we need to fix xfs_repair not to trash the root
inode without first checking that the current root inode pointer is
invalid...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2019-12-01 23:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 18:08 [RFC-PATCH] xfs: do not update sunit/swidth in the superblock to match those provided during mount Alex Lyakas
2019-11-22 15:43 ` Brian Foster
2019-11-24 9:13 ` Alex Lyakas
2019-11-24 16:40 ` Darrick J. Wong
2019-11-24 17:38 ` Eric Sandeen
2019-11-25 13:07 ` Brian Foster
2019-11-26 8:50 ` Alex Lyakas
2019-11-25 13:07 ` Brian Foster
2019-11-26 8:49 ` Alex Lyakas
2019-11-26 11:54 ` Brian Foster
2019-11-26 13:37 ` Alex Lyakas
2019-11-26 16:53 ` Eric Sandeen
2019-11-27 14:19 ` Christoph Hellwig
2019-11-27 15:19 ` Brian Foster
2019-11-30 20:28 ` Dave Chinner
2019-12-01 9:00 ` Alex Lyakas
2019-12-01 21:57 ` Dave Chinner
2019-12-02 8:07 ` Alex Lyakas
2019-12-01 23:29 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191201232904.GC2695@dread.disaster.area \
--to=david@fromorbit.com \
--cc=alex@zadara.com \
--cc=bfoster@redhat.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox