Re: [PATCH v4] sched/core: Preempt current task in favour of bound kthread

Srikar Dronamraju
2019-12-12T15:07:55Z

* Peter Zijlstra <peterz@infradead.org> [2019-12-12 11:10:31]:

>
> +static struct sched_entity *
> +__pick_next_entity(struct cfs_rq *cfs_rq, struct sched_entity *curr);

I think we already have __pick_next_entity in kernel/sched/fair.c

static struct sched_entity *__pick_next_entity(struct sched_entity *se)
{
struct rb_node *next = rb_next(&se->run_node);

if (!next)
return NULL;

return rb_entry(next, struct sched_entity, run_node);
}

I checked in v5.5-rc1, v5.4 and tip/master too. Let me know if you were
referring to a different version of code.

So I modified the only place its called to the newer
__pick_next_entity(cfs_rq, curr);

But wanted to verify if that's what you had in mind.

--
Thanks and Regards
Srikar Dronamraju