From: Omar Sandoval <osandov@osandov.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH] xfs: fix log reservation overflows when allocating large rt extents
Date: Thu, 5 Dec 2019 11:23:37 -0800 [thread overview]
Message-ID: <20191205192337.GC18377@vader> (raw)
In-Reply-To: <20191204163809.GP7335@magnolia>
On Wed, Dec 04, 2019 at 08:38:09AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Omar Sandoval reported that a 4G fallocate on the realtime device causes
> filesystem shutdowns due to a log reservation overflow that happens when
> we log the rtbitmap updates. Factor rtbitmap/rtsummary updates into the
> the tr_write and tr_itruncate log reservation calculation.
>
> "The following reproducer results in a transaction log overrun warning
> for me:
>
> mkfs.xfs -f -r rtdev=/dev/vdc -d rtinherit=1 -m reflink=0 /dev/vdb
> mount -o rtdev=/dev/vdc /dev/vdb /mnt
> fallocate -l 4G /mnt/foo
>
> Reported-by: Omar Sandoval <osandov@osandov.com>
This one works, as well. Thanks!
Reported-and-tested-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/libxfs/xfs_trans_resv.c | 96 ++++++++++++++++++++++++++++++++--------
> 1 file changed, 77 insertions(+), 19 deletions(-)
next prev parent reply other threads:[~2019-12-05 19:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 16:38 [PATCH] xfs: fix log reservation overflows when allocating large rt extents Darrick J. Wong
2019-12-05 19:23 ` Omar Sandoval [this message]
2019-12-12 23:01 ` Darrick J. Wong
2019-12-13 12:18 ` Brian Foster
2019-12-13 20:19 ` Darrick J. Wong
2019-12-16 12:23 ` Brian Foster
2019-12-16 16:47 ` Darrick J. Wong
2019-12-16 18:00 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205192337.GC18377@vader \
--to=osandov@osandov.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox