Re: [PATCH v3] generic: test truncating mixed written/unwritten XFS realtime extent

Darrick J. Wong
2019-12-04T00:14:50Z

Looks good to me,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> Changes from v2 -> v3:
>
> - Use _create_loop_device and _destroy_loop_device instead of losetup
>
> Changes from v1 -> v2:
>
> - If rtdev is not configured, fall back to loop device on test
> filesystem
> - Use XFS_IO_PROG instead of fallocate/sync/dd
> - Use truncate instead of rm
> - Add comments explaining the steps
>
> tests/generic/589 | 100 ++++++++++++++++++++++++++++++++++++++++++
> tests/generic/589.out | 2 +
> tests/generic/group | 1 +
> 3 files changed, 103 insertions(+)
> create mode 100755 tests/generic/589
> create mode 100644 tests/generic/589.out
>
> diff --git a/tests/generic/589 b/tests/generic/589
> new file mode 100755
> index 00000000..aab37bb4
> --- /dev/null
> +++ b/tests/generic/589
> @@ -0,0 +1,100 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2019 Facebook. All Rights Reserved.
> +#
> +# FS QA Test 589
> +#
> +# Test "xfs: fix realtime file data space leak" and "xfs: don't check for AG
> +# deadlock for realtime files in bunmapi". On XFS without the fix, truncate
> +# will hang forever. On other filesystems, this just tests writing into big
> +# fallocates.
> +#
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + rm -f $tmp.*
> + test -n "$loop" && _destroy_loop_device "$loop"
> + rm -f "$TEST_DIR/$seq"
> +}
> +
> +. ./common/rc
> +. ./common/filter
> +
> +rm -f $seqres.full
> +
> +_supported_fs generic
> +_supported_os Linux
> +_require_scratch_nocheck
> +
> +maxextlen=$((0x1fffff))
> +bs=4096
> +rextsize=4
> +filesz=$(((maxextlen + 1) * bs))
> +
> +extra_options=""
> +# If we're testing XFS, set up the realtime device to reproduce the bug.
> +if [[ $FSTYP = xfs ]]; then
> + # If we don't have a realtime device, set up a loop device on the test
> + # filesystem.
> + if [[ $USE_EXTERNAL != yes || -z $SCRATCH_RTDEV ]]; then
> + _require_test
> + loopsz="$((filesz + (1 << 26)))"
> + _require_fs_space "$TEST_DIR" $((loopsz / 1024))
> + $XFS_IO_PROG -c "truncate $loopsz" -f "$TEST_DIR/$seq"
> + loop="$(_create_loop_device "$TEST_DIR/$seq")"
> + USE_EXTERNAL=yes
> + SCRATCH_RTDEV="$loop"
> + fi
> + extra_options="$extra_options -bsize=$bs"
> + extra_options="$extra_options -r extsize=$((bs * rextsize))"
> + extra_options="$extra_options -d agsize=$(((maxextlen + 1) * bs / 2)),rtinherit=1"
> +fi
> +_scratch_mkfs $extra_options >>$seqres.full 2>&1