Re: [PATCH 02/33] xfs: reject invalid flags combinations in XFS_IOC_ATTRMULTI_BY_HANDLE

Christoph Hellwig
2019-12-24T11:56:39Z

On Wed, Dec 18, 2019 at 01:29:52PM -0800, Darrick J. Wong wrote:
> On Thu, Dec 12, 2019 at 11:54:02AM +0100, Christoph Hellwig wrote:
> > While the flags field in the ABI and the on-disk format allows for
> > multiple namespace flags, that is a logically invalid combination that
> > scrub complains about. Reject it at the ioctl level, as all other
> > interface already get this right at higher levels.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Looks ok I think. We never have attrs in two namespaces at once...
> assuming that "attr_multi(3)" is the right manpage for all this?

Yes, that is the man page for the interface.