Re: [PATCH 03/33] xfs: also remove cached ACLs when removing the underlying attr

Christoph Hellwig
2019-12-24T11:57:18Z

On Wed, Dec 18, 2019 at 01:31:08PM -0800, Darrick J. Wong wrote:
> On Thu, Dec 12, 2019 at 11:54:03AM +0100, Christoph Hellwig wrote:
> > We should not just invalidate the ACL when setting the underlying
> > attribute, but also when removing it. The ioctl interface gets that
> > right, but the normal xattr inteface skipped the xfs_forget_acl due
> > to an early return.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Shouldn't someone have a testcase for this?

adding Andreas, who wrote this code originally.