Re: [PATCH 1/3] xfs: open code insert range extent split helper

Christoph Hellwig
2019-12-24T11:18:42Z

On Fri, Dec 13, 2019 at 12:12:56PM -0500, Brian Foster wrote:
> The insert range operation currently splits the extent at the target
> offset in a separate transaction and lock cycle from the one that
> shifts extents. In preparation for reworking insert range into an
> atomic operation, lift the code into the caller so it can be easily
> condensed to a single rolling transaction and lock cycle and
> eliminate the helper. No functional changes.

The helper already is rather questionable as-is, so even without looking
at the following patches:

Reviewed-by: Christoph Hellwig <hch@lst.de>